You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wangyum (via GitHub)" <gi...@apache.org> on 2023/06/14 03:28:04 UTC
[GitHub] [spark] wangyum opened a new pull request, #41583: [SPARK-44048][DOCS] Remove sql-migration-old.md
wangyum opened a new pull request, #41583:
URL: https://github.com/apache/spark/pull/41583
### What changes were proposed in this pull request?
This PR removes sql-migration-old.md.
### Why are the changes needed?
We can use sql-migration-guide.md directly without redirection:
<img width="548" alt="image" src="https://github.com/apache/spark/assets/5399861/fdef4bea-7438-4570-b8ea-91a1a7fa86f5">
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #41583: [SPARK-44048][DOCS] Remove sql-migration-old.md
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41583:
URL: https://github.com/apache/spark/pull/41583#issuecomment-1590624822
Merged to master for Apache Spark 3.5.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #41583: [SPARK-44048][DOCS] Remove sql-migration-old.md
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #41583: [SPARK-44048][DOCS] Remove sql-migration-old.md
URL: https://github.com/apache/spark/pull/41583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #41583: [SPARK-44048][DOCS] Remove sql-migration-old.md
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41583:
URL: https://github.com/apache/spark/pull/41583#issuecomment-1590625644
According to the affected version info of JIRA, I landed it to `master` branch only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41583: [SPARK-44048][DOCS] Remove sql-migration-old.md
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #41583:
URL: https://github.com/apache/spark/pull/41583#discussion_r1228964880
##########
docs/_data/menu-sql.yaml:
##########
@@ -71,7 +71,7 @@
- text: PySpark Usage Guide for Pandas with Apache Arrow
url: sql-pyspark-pandas-with-arrow.html
- text: Migration Guide
- url: sql-migration-old.html
+ url: sql-migration-guide.html
Review Comment:
Do you happen to know the history?
##########
docs/_data/menu-sql.yaml:
##########
@@ -71,7 +71,7 @@
- text: PySpark Usage Guide for Pandas with Apache Arrow
url: sql-pyspark-pandas-with-arrow.html
- text: Migration Guide
- url: sql-migration-old.html
+ url: sql-migration-guide.html
Review Comment:
Do you happen to know the history about `-old.html`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a diff in pull request #41583: [SPARK-44048][DOCS] Remove sql-migration-old.md
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on code in PR #41583:
URL: https://github.com/apache/spark/pull/41583#discussion_r1228980548
##########
docs/_data/menu-sql.yaml:
##########
@@ -71,7 +71,7 @@
- text: PySpark Usage Guide for Pandas with Apache Arrow
url: sql-pyspark-pandas-with-arrow.html
- text: Migration Guide
- url: sql-migration-old.html
+ url: sql-migration-guide.html
Review Comment:
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41583: [SPARK-44048][DOCS] Remove sql-migration-old.md
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #41583:
URL: https://github.com/apache/spark/pull/41583#discussion_r1229012981
##########
docs/_data/menu-sql.yaml:
##########
@@ -71,7 +71,7 @@
- text: PySpark Usage Guide for Pandas with Apache Arrow
url: sql-pyspark-pandas-with-arrow.html
- text: Migration Guide
- url: sql-migration-old.html
+ url: sql-migration-guide.html
Review Comment:
It was to keep the old URL so existing links are not broken. I think it's been pretty a while so I think we can just remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org