You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/06/16 15:59:51 UTC
[GitHub] [incubator-yunikorn-k8shim] codecov-commenter edited a comment on pull request #107: [YUNIKORN-55] Add pod labels and annotations to allocation ask attributes
codecov-commenter edited a comment on pull request #107:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/107#issuecomment-643998726
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/107?src=pr&el=h1) Report
> Merging [#107](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/107?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/ace5f8bd64ee7f7a0d6c79dce055192390f11bcd&el=desc) will **increase** coverage by `0.51%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/107?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 53.13% 53.65% +0.51%
==========================================
Files 32 32
Lines 3030 3040 +10
==========================================
+ Hits 1610 1631 +21
+ Misses 1357 1346 -11
Partials 63 63
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/107?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/107/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `60.16% <100.00%> (ø)` | |
| [pkg/common/si\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/107/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `56.04% <100.00%> (+21.47%)` | :arrow_up: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/107/diff?src=pr&el=tree#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `85.32% <0.00%> (-1.84%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/107?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/107?src=pr&el=footer). Last update [ace5f8b...fb6be8e](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/107?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org