You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2016/01/12 18:53:55 UTC
Review Request 42202: RU step retries overwrite logs from previous run
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42202/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
Bugs: AMBARI-14631
https://issues.apache.org/jira/browse/AMBARI-14631
Repository: ambari
Description
-------
When we retry an RU step that had failed, the logs from previous runs are overwritten. As a consequence we loose failure logs because of retry. We should backup old configs in such scenarios.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 350c568
ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py e4a47d1
Diff: https://reviews.apache.org/r/42202/diff/
Testing
-------
Ran 424 tests in 5.561s
OK
Process finished with exit code 0
Thanks,
Dmitro Lisnichenko
Re: Review Request 42202: RU step retries overwrite logs from
previous run
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42202/#review114047
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Jan. 12, 2016, 5:53 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42202/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 5:53 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14631
> https://issues.apache.org/jira/browse/AMBARI-14631
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When we retry an RU step that had failed, the logs from previous runs are overwritten. As a consequence we loose failure logs because of retry. We should backup old configs in such scenarios.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 350c568
> ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py e4a47d1
>
> Diff: https://reviews.apache.org/r/42202/diff/
>
>
> Testing
> -------
>
> Ran 424 tests in 5.561s
>
> OK
>
> Process finished with exit code 0
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 42202: RU step retries overwrite logs from
previous run
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42202/#review114026
-----------------------------------------------------------
Ship it!
Nice!
- Alejandro Fernandez
On Jan. 12, 2016, 5:53 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42202/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 5:53 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14631
> https://issues.apache.org/jira/browse/AMBARI-14631
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When we retry an RU step that had failed, the logs from previous runs are overwritten. As a consequence we loose failure logs because of retry. We should backup old configs in such scenarios.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 350c568
> ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py e4a47d1
>
> Diff: https://reviews.apache.org/r/42202/diff/
>
>
> Testing
> -------
>
> Ran 424 tests in 5.561s
>
> OK
>
> Process finished with exit code 0
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 42202: RU step retries overwrite logs from
previous run
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42202/#review114029
-----------------------------------------------------------
Ship it!
Ship It!
- bhuvnesh chaudhary
On Jan. 12, 2016, 5:53 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42202/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 5:53 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-14631
> https://issues.apache.org/jira/browse/AMBARI-14631
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When we retry an RU step that had failed, the logs from previous runs are overwritten. As a consequence we loose failure logs because of retry. We should backup old configs in such scenarios.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 350c568
> ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py e4a47d1
>
> Diff: https://reviews.apache.org/r/42202/diff/
>
>
> Testing
> -------
>
> Ran 424 tests in 5.561s
>
> OK
>
> Process finished with exit code 0
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>