You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/11/29 08:11:48 UTC
[GitHub] [dubbo-samples] chang6666 opened a new pull request, #594: add Spring Boot 3.0 demo
chang6666 opened a new pull request, #594:
URL: https://github.com/apache/dubbo-samples/pull/594
add Spring Boot 3.0 demo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] CrazyHZM commented on a diff in pull request #594: add Spring Boot 3.0 demo
Posted by GitBox <gi...@apache.org>.
CrazyHZM commented on code in PR #594:
URL: https://github.com/apache/dubbo-samples/pull/594#discussion_r1034431117
##########
dubbo-samples-spring-boot-3.x/pom.xml:
##########
@@ -0,0 +1,120 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-samples-spring-boot-3.x</artifactId>
+ <version>1.0-SNAPSHOT</version>
+ <modules>
+ <module>dubbo-samples-spring-boot-3.x-interface</module>
+ <module>dubbo-samples-spring-boot-3.x-provider</module>
+ <module>dubbo-samples-spring-boot-3.x-consumer</module>
+ </modules>
+ <packaging>pom</packaging>
+
+
+ <properties>
+ <maven.compiler.source>17</maven.compiler.source>
+ <maven.compiler.target>17</maven.compiler.target>
+ <spring.version>6.0.2</spring.version>
+ <dubbo.version>3.2.0-beta.2-SNAPSHOT</dubbo.version>
Review Comment:
3.2.0-beta.2 has been released
##########
pom.xml:
##########
@@ -93,21 +93,7 @@
<module>dubbo-samples-triple-reactor</module>
<module>dubbo-samples-rocketmq</module>
<module>dubbo-samples-port-unification</module>
+ <module>dubbo-samples-spring-boot-3.x</module>
</modules>
- <repositories>
- <repository>
- <id>apache.snapshots.https</id>
- <name>Apache Development Snapshot Repository</name>
- <url>https://repository.apache.org/content/repositories/snapshots</url>
- <layout>default</layout>
- <releases>
- <enabled>false</enabled>
- </releases>
- <snapshots>
- <enabled>true</enabled>
- <updatePolicy>daily</updatePolicy>
- </snapshots>
- </repository>
- </repositories>
Review Comment:
Why do you want to delete this?
##########
dubbo-samples-spring-boot-3.x/dubbo-samples-spring-boot-3.x-consumer/src/main/java/org/apache/dubbo/springboot/demo/consumer/ConsumerApplication.java:
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.springboot.demo.consumer;
+
+import org.apache.dubbo.config.annotation.DubboReference;
+import org.apache.dubbo.config.spring.context.annotation.EnableDubbo;
+import org.apache.dubbo.springboot.demo.DemoService;
+import org.springframework.boot.SpringApplication;
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+import org.springframework.context.ConfigurableApplicationContext;
+import org.springframework.core.metrics.StartupStep;
+import org.springframework.stereotype.Service;
+
+import java.util.Properties;
+
+/**
+ * @author <a href="changningbo1995@gmail.com">James</a>
+ * @since 2022/11/13
+ */
Review Comment:
Remove author information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chang6666 closed pull request #594: add Spring Boot 3.0 demo
Posted by GitBox <gi...@apache.org>.
chang6666 closed pull request #594: add Spring Boot 3.0 demo
URL: https://github.com/apache/dubbo-samples/pull/594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org