You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/04 10:46:38 UTC
[GitHub] [ozone] mukul1987 opened a new pull request #1989: HDDS-4899. Add SCM HA to Chaos tests.
mukul1987 opened a new pull request #1989:
URL: https://github.com/apache/ozone/pull/1989
## What changes were proposed in this pull request?
This jira adds SCM HA to Chaos tests
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4899
## How was this patch tested?
Added a new chaos test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on pull request #1989: HDDS-4899. Add SCM HA to Chaos tests.
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1989:
URL: https://github.com/apache/ozone/pull/1989#issuecomment-797360817
Please hold on the merge util we finish merging master back to 2823. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on a change in pull request #1989: HDDS-4899. Add SCM HA to Chaos tests.
Posted by GitBox <gi...@apache.org>.
bshashikant commented on a change in pull request #1989:
URL: https://github.com/apache/ozone/pull/1989#discussion_r595774817
##########
File path: hadoop-ozone/fault-injection-test/mini-chaos-tests/src/test/java/org/apache/hadoop/ozone/MiniOzoneChaosCluster.java
##########
@@ -382,4 +408,45 @@ public void shutdownHddsDatanode(DatanodeDetails dn) throws IOException {
public boolean shouldStop(DatanodeDetails dn) {
return !failedDnSet.contains(dn);
}
+
+ // StorageContainerManager specific
+ public static int getNumberOfScmToFail() {
+ return 1;
+ }
+
+ public Set<StorageContainerManager> scmToFail() {
+ int numNodesToFail = getNumberOfScmToFail();
+ if (failedScmSet.size() >= numStorageContainerManagers/2) {
+ return Collections.emptySet();
+ }
+
+ int numOms = getStorageContainerManagersList().size();
+ Set<StorageContainerManager> scms = new HashSet<>();
+ for (int i = 0; i < numNodesToFail; i++) {
+ int failedNodeIndex = FailureManager.getBoundedRandomIndex(numOms);
Review comment:
numOms--> numSCMs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant merged pull request #1989: HDDS-4899. Add SCM HA to Chaos tests.
Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #1989:
URL: https://github.com/apache/ozone/pull/1989
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 commented on a change in pull request #1989: HDDS-4899. Add SCM HA to Chaos tests.
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on a change in pull request #1989:
URL: https://github.com/apache/ozone/pull/1989#discussion_r595883761
##########
File path: hadoop-ozone/fault-injection-test/mini-chaos-tests/src/test/java/org/apache/hadoop/ozone/MiniOzoneChaosCluster.java
##########
@@ -382,4 +408,45 @@ public void shutdownHddsDatanode(DatanodeDetails dn) throws IOException {
public boolean shouldStop(DatanodeDetails dn) {
return !failedDnSet.contains(dn);
}
+
+ // StorageContainerManager specific
+ public static int getNumberOfScmToFail() {
+ return 1;
+ }
+
+ public Set<StorageContainerManager> scmToFail() {
+ int numNodesToFail = getNumberOfScmToFail();
+ if (failedScmSet.size() >= numStorageContainerManagers/2) {
+ return Collections.emptySet();
+ }
+
+ int numOms = getStorageContainerManagersList().size();
+ Set<StorageContainerManager> scms = new HashSet<>();
+ for (int i = 0; i < numNodesToFail; i++) {
+ int failedNodeIndex = FailureManager.getBoundedRandomIndex(numOms);
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #1989: HDDS-4899. Add SCM HA to Chaos tests.
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1989:
URL: https://github.com/apache/ozone/pull/1989#issuecomment-801699597
Thanks @mukul1987 for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org