[GitHub] [airflow] eladkal commented on a diff in pull request #24415: Add TrinoOperator

[GitBox <gi...@apache.org>]

eladkal commented on code in PR #24415:
URL: https://github.com/apache/airflow/pull/24415#discussion_r895756818


##########
airflow/providers/trino/operators/trino.py:
##########
@@ -0,0 +1,81 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""This module contains the Trino operator."""
+
+from typing import TYPE_CHECKING, Any, Callable, Optional, Sequence
+
+from airflow.models import BaseOperator
+from airflow.providers.trino.hooks.trino import TrinoHook
+
+if TYPE_CHECKING:
+    from airflow.utils.context import Context
+
+
+class TrinoOperator(BaseOperator):
+    """
+    Executes sql code using a specific Trino query Engine.
+
+    .. seealso::
+        For more information on how to use this operator, take a look at the guide:
+        :ref:`howto/operator:TrinoOperator`
+
+    :param sql: the SQL code to be executed as a single string, or a reference
+    to a template file.Template references are recognized by str ending in '.sql'
+    :param trino_conn_id: id of the connection config for the target Trino
+        environment
+    :param autocommit: What to set the connection's autocommit setting to
+            before executing the query
+    :param handler: The result handler which is called with the result of each statement.
+    :param parameters: (optional) the parameters to render the SQL query with.
+    """
+
+    template_fields: Sequence[str] = ('sql',)
+    template_fields_renderers = {'sql': 'sql'}
+    template_ext: Sequence[str] = ('.sql',)
+    ui_color = '#ededed'
+
+    def __init__(
+        self,
+        *,
+        sql: str,
+        trino_conn_id: str = "trino_default",
+        autocommit: bool = False,
+        parameters: Optional[tuple] = None,
+        handler: Optional[Callable] = None,
+        **kwargs: Any,
+    ) -> None:
+        super().__init__(**kwargs)
+        self.sql = sql
+        self.trino_conn_id = trino_conn_id
+        self.hook: Optional[TrinoHook] = None
+        self.autocommit = autocommit
+        self.parameters = parameters
+        self.handler = handler
+
+    def get_hook(self) -> TrinoHook:
+        """Get Trino hook"""
+        return TrinoHook(
+            trino_conn_id=self.trino_conn_id,
+        )
+
+    def execute(self, context: 'Context') -> None:
+        """Execute Trino SQL"""
+        self.hook = self.get_hook()
+        self.hook.run(
+            sql=self.sql, autocommit=self.autocommit, parameters=self.parameters, handler=self.handler

Review Comment:
   This will work only with a single query won't it?
   I believe This PR is depended on https://github.com/apache/airflow/issues/23112
   
   I think it's worth waiting for https://github.com/apache/airflow/pull/23971 to be completed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org