[GitHub] [sling-org-apache-sling-feature-analyser] hsaginor commented on a change in pull request #14: Zip file extract

[GitBox <gi...@apache.org>]

hsaginor commented on a change in pull request #14: Zip file extract
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/14#discussion_r291681833
 
 

 ##########
 File path: src/main/java/org/apache/sling/feature/scanner/impl/FelixFrameworkScanner.java
 ##########
 @@ -143,23 +144,31 @@ public Manifest getManifest() {
     Map<String,String> getFrameworkProperties(final Map<String,String> appProps, final File framework)
     throws IOException {
         final Map<String, Properties> propsMap = new HashMap<>();
-        try (final ZipInputStream zis = new ZipInputStream(new FileInputStream(framework)) ) {
-            boolean done = false;
-            while ( !done ) {
-                final ZipEntry entry = zis.getNextEntry();
-                if ( entry == null ) {
-                    done = true;
-                } else {
+        ZipFile zipFile = null;
 
 Review comment:
   @karlpauls Just pushed the changes as suggested. Thank you for reviewing this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services