[GitHub] [arrow] lidavidm commented on a diff in pull request #37360: GH-37212: [C++] IO: Add FromString to ::arrow::io::BufferReader

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #37360:
URL: https://github.com/apache/arrow/pull/37360#discussion_r1307445092


##########
cpp/src/arrow/flight/sql/client.cc:
##########
@@ -519,13 +519,17 @@ arrow::Result<std::shared_ptr<PreparedStatement>> PreparedStatement::ParseRespon
 
   std::shared_ptr<Schema> dataset_schema;
   if (!serialized_dataset_schema.empty()) {
-    io::BufferReader dataset_schema_reader(serialized_dataset_schema);
+    // Create a non-owned Buffer to avoid copying

Review Comment:
   Should be OK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org