You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/02/25 23:08:59 UTC

[GitHub] [beam] lostluck commented on pull request #16956: [BEAM-13917] Improve coverage of databaseio package

lostluck commented on pull request #16956:
URL: https://github.com/apache/beam/pull/16956#issuecomment-1051345639


   To answer the description questions: The risk in taking this dep is minimal:
   1. Test dependencies don't get compiled into non-test code.
   2. We have it working at version X, and depend on that. Even if they make breaking changes, we'll still be on version X. The main risk is if a user depends on X+N with breaking behaviors and then also runs Our tests, which would hoist things up to X+N.  But it's only in tests, so it still doesn't break user code.
   
   The only other alternative is setting up an in memory SQL lite instance instead. 
   
   Overall, this package should likely be commented and direct users to the Xlang JDBCIO package instead, which will perform better at the moment. We will want to revamp this for Go native implementation eventually, but this is better than nothing.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org