You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/04 23:57:59 UTC

[GitHub] [spark] viirya commented on pull request #32777: [SPARK-35640][SQL] Refactor Parquet vectorized reader to remove duplicated code paths

viirya commented on pull request #32777:
URL: https://github.com/apache/spark/pull/32777#issuecomment-855140795


   IIRC, the original intention is to avoid the cost of virtual calls. If we are sure the performance isn't an issue anymore, deduplication of code is more welcome direction, I think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org