[GitHub] [lucene] rmuir commented on a diff in pull request #886: LUCENE-10560: Reduce the number of bytes compared while constructing an OrdinalMap.

[GitBox <gi...@apache.org>]

rmuir commented on code in PR #886:
URL: https://github.com/apache/lucene/pull/886#discussion_r871487727


##########
lucene/core/src/java/org/apache/lucene/index/TermsEnum.java:
##########
@@ -105,6 +105,9 @@ public enum SeekStatus {
    */
   public abstract long ord() throws IOException;
 
+  // TODO: clean this up
+  public long size() { return Long.MAX_VALUE; }

Review Comment:
   i think we could make it abstract and match javadocs of `Terms.size` ? it is a little strange to have it in both places, but i see the problem that there is no "Terms" here. and for most implementations it will be easy to implement as they can just implement with their existing Terms.size.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org