You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/10/01 19:32:47 UTC

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2382: allow more then one battery

kasjer commented on a change in pull request #2382:
URL: https://github.com/apache/mynewt-core/pull/2382#discussion_r498469917



##########
File path: hw/battery/src/battery.c
##########
@@ -25,7 +25,12 @@
 #include <battery/battery_prop.h>
 #include <battery/battery_drv.h>
 
+
+#if MYNEWT_VAL(BATTERY_MAX_COUNT)

Review comment:
       You are quite right, BATTERY_DRIVERS_MAX is also missing from syscfg.yml.
   Here is pull request #2384 that fixes that.
   
   If you still want to contribute your change with syscfg definition please don't hesitate to use force push to your branch so we can limit number of commits with names like `fixes review comments`, and we can merge you commits without squashing them first (that can drop authorship).
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org