You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by chouqin <gi...@git.apache.org> on 2015/04/28 08:25:58 UTC
[GitHub] spark pull request: [SPARK-7181][CORE]fix inifite loop in External...
GitHub user chouqin opened a pull request:
https://github.com/apache/spark/pull/5737
[SPARK-7181][CORE]fix inifite loop in Externalsorter's mergeWithAggregation
see [SPARK-7181](https://issues.apache.org/jira/browse/SPARK-7181).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chouqin/spark externalsorter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5737.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5737
----
commit 2924b93b0d16e98fb045138e2bc0f8d94b1e0bfa
Author: Qiping Li <li...@gmail.com>
Date: 2015-04-28T06:22:54Z
fix inifite loop in Externalsorter's mergeWithAggregation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7181][CORE]fix inifite loop in External...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5737
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7181][CORE]fix inifite loop in External...
Posted by chouqin <gi...@git.apache.org>.
Github user chouqin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5737#discussion_r29304781
--- Diff: core/src/test/scala/org/apache/spark/util/collection/ExternalSorterSuite.scala ---
@@ -506,7 +506,10 @@ class ExternalSorterSuite extends FunSuite with LocalSparkContext with PrivateMe
val agg = new Aggregator[Int, Int, Int](i => i, (i, j) => i + j, (i, j) => i + j)
val ord = implicitly[Ordering[Int]]
val sorter = new ExternalSorter(Some(agg), Some(new HashPartitioner(3)), Some(ord), None)
- sorter.insertAll((0 until 100000).iterator.map(i => (i / 2, i)))
+
+ // avoid combine before spill
+ sorter.insertAll((0 until 50000).iterator.map(i => (i , 2 * i)))
+ sorter.insertAll((0 until 50000).iterator.map(i => (i, 2 * i + 1)))
--- End diff --
Yes, it failed on my computer(this testcase didn't stop). I set the memory limit to a small value on my computer to ganrantee spills. I think we can also set `spark.shuffle.memoryFraction` to a small value to do this. The origin value of `spark.shuffle.memoryFraction` is 0.001, I don't know if it can ganrantee spills. If not, we should change it to a smaller value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7181][CORE]fix inifite loop in External...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5737#discussion_r29281205
--- Diff: core/src/test/scala/org/apache/spark/util/collection/ExternalSorterSuite.scala ---
@@ -506,7 +506,10 @@ class ExternalSorterSuite extends FunSuite with LocalSparkContext with PrivateMe
val agg = new Aggregator[Int, Int, Int](i => i, (i, j) => i + j, (i, j) => i + j)
val ord = implicitly[Ordering[Int]]
val sorter = new ExternalSorter(Some(agg), Some(new HashPartitioner(3)), Some(ord), None)
- sorter.insertAll((0 until 100000).iterator.map(i => (i / 2, i)))
+
+ // avoid combine before spill
+ sorter.insertAll((0 until 50000).iterator.map(i => (i , 2 * i)))
+ sorter.insertAll((0 until 50000).iterator.map(i => (i, 2 * i + 1)))
--- End diff --
does this actually run the case that you modified? (i.e. did this modified test fail before your fix?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7181][CORE]fix inifite loop in External...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5737#issuecomment-96944305
[Test build #31123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31123/consoleFull) for PR 5737 at commit [`2924b93`](https://github.com/apache/spark/commit/2924b93b0d16e98fb045138e2bc0f8d94b1e0bfa).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7181][CORE]fix inifite loop in External...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5737#issuecomment-96967158
[Test build #31123 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31123/consoleFull) for PR 5737 at commit [`2924b93`](https://github.com/apache/spark/commit/2924b93b0d16e98fb045138e2bc0f8d94b1e0bfa).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7181][CORE]fix inifite loop in External...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5737#issuecomment-97035568
LGTM. CC @mateiz for a quick look, as the original author.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7181][CORE]fix inifite loop in External...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5737#issuecomment-97177664
Hm, did we just never run into that else case? LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org