You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Jon Moore (JIRA)" <ji...@apache.org> on 2011/03/22 21:18:06 UTC
[jira] [Commented] (HTTPCLIENT-1073) cache module generates
exceptions for non-compliant responses without consuming response bodies
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009820#comment-13009820 ]
Jon Moore commented on HTTPCLIENT-1073:
---------------------------------------
I believe the correct fix for this problem is one of:
(a) document the proper workaround for the client to avoid the connection leak (perhaps using HttpUriRequest#abort)
(b) have the caching module consume the response body if present before throwing the exception
(c) don't throw an exception here and just treat the noncompliant response as cache-invalidating and uncacheable.
I think my personal preference is (c) and will start working on a patch to that effect.
> cache module generates exceptions for non-compliant responses without consuming response bodies
> -----------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1073
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1073
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Cache
> Affects Versions: 4.1 Beta1, 4.1 Final, 4.1.1, 4.2 Final
> Reporter: Jon Moore
> Assignee: Jon Moore
>
> In the ResponseProtocolCompliance class, the caching module checks the incoming origin response to attempt to make it compliant with RFC2616. However, if there are instances where this is not possible, it currently throws an exception without consuming the origin response body; this causes a connection leak if the general try..catch..finally pattern documented on the HttpClient interface Javadoc is followed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org