[GitHub] [airflow] eladkal commented on a diff in pull request #29908: Fix empty paths in Vault secrets backend

["eladkal (via GitHub)" <gi...@apache.org>]

eladkal commented on code in PR #29908:
URL: https://github.com/apache/airflow/pull/29908#discussion_r1125561432


##########
airflow/providers/hashicorp/secrets/vault.py:
##########
@@ -175,8 +175,10 @@ def get_response(self, conn_id: str) -> dict | None:
         mount_point, conn_key = self._parse_path(conn_id)
         if self.connections_path is None or conn_key is None:
             return None
-
-        secret_path = self.build_path(self.connections_path, conn_key)
+        if self.connections_path == "":
+            secret_path = conn_key

Review Comment:
   why do we consider `None` and `""` to be dealt differently?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org