You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Andrea Del Bene (JIRA)" <ji...@apache.org> on 2015/06/04 16:18:38 UTC

[jira] [Comment Edited] (WICKET-5909) Session style is not taken into account when loading mounted resources.

    [ https://issues.apache.org/jira/browse/WICKET-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572837#comment-14572837 ] 

Andrea Del Bene edited comment on WICKET-5909 at 6/4/15 2:18 PM:
-----------------------------------------------------------------

I've create a new branch to work for a fix for 7.x. It's called  WICKET-5906-7.x (see https://git1-us-west.apache.org/repos/asf?p=wicket.git;a=shortlog;h=refs/heads/WICKET-5906-7.x). This solution is slightly different from the previous patch I've attached. I've moved most of the logic from AbstractResourceReferenceMapper to ResourceUtil in order to share it across different mappers or classes that needs to encode/decode resource attributes in the URL.
Maybe is more radical as solution but I prefer it over the previous idea of turning ResourceMapper into a subclass of AbstractResourceReferenceMapper.

UPDATE: I've just realized that I used the wrong issue number, 5906 instead of 5909


was (Author: bitstorm):
I've create a new branch to work for a fix for 7.x. It's called  WICKET-5906-7.x (see https://git1-us-west.apache.org/repos/asf?p=wicket.git;a=shortlog;h=refs/heads/WICKET-5906-7.x). This solution is slightly different from the previous patch I've attached. I've moved most of the logic from AbstractResourceReferenceMapper to ResourceUtil in order to share it across different mappers or classes that needs to encode/decode resource attributes in the URL.
Maybe is more radical as solution but I prefer it over the previous idea of turning ResourceMapper into a subclass of AbstractResourceReferenceMapper.

> Session style is not taken into account when loading mounted resources.
> -----------------------------------------------------------------------
>
>                 Key: WICKET-5909
>                 URL: https://issues.apache.org/jira/browse/WICKET-5909
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 7.0.0-M5, 6.19.0
>            Reporter: Sergiy Barlabanov
>            Assignee: Martin Grigorov
>         Attachments: style-bug.zip, wicket.patch
>
>
> Session#getStyle is not considered when a mounted package resource is loaded. Wicket loads the default one.
> If the resource is not mounted, everything works fine and Wicket delivers the correct resource file.
> Quickstart is attached. There are two CSS files: styled.css and styled_orange.css. The corresponding package resource is mounted. The session style is set to orange in WicketApplication#newSession. Expected behavior is that styled_orange.css is delivered to a browser. Instead styled.css is delivered.
> There is a workaround: see WorkaroundResourceStreamLocator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)