[GitHub] [iceberg] rdblue commented on a change in pull request #1618: dynamically load custom FileIO implementation

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1618:
URL: https://github.com/apache/iceberg/pull/1618#discussion_r516148342



##########
File path: core/src/main/java/org/apache/iceberg/hadoop/ConfigProperties.java
##########
@@ -25,4 +25,6 @@ private ConfigProperties() {
   }
 
   public static final String ENGINE_HIVE_ENABLED = "iceberg.engine.hive.enabled";
+
+  public static final String CUSTOM_FILE_IO_IMPL = "iceberg.fileio.impl";

Review comment:
       There are config properties from both Flink and Spark that we use when constructing the Hive and Hadoop catalogs. And for #1640, we are talking about using an initialization method to set the config using a string map (and a catalog name). While these classes don't pull their own config out of a map, I think of the config as coming from a map of config properties.
   
   Sorry for the confusion. I think we should configure this however the catalog is configured, which will very likely be a string map passed to an init method in the future.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org