You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2021/06/29 21:21:19 UTC
[superset] branch hugh/fix-port-err-num created (now 88655a6)
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a change to branch hugh/fix-port-err-num
in repository https://gitbox.apache.org/repos/asf/superset.git.
at 88655a6 change reference for invalid port to 1031
This branch includes the following new commits:
new 44504f5 Merge branch 'master' of https://github.com/apache/superset into pexdax/db-connection-ui
new 88655a6 change reference for invalid port to 1031
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 02/02: change reference for invalid port to 1031
Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hugh/fix-port-err-num
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 88655a6d0ef0f9d15e3eb7c5cf9d4bce1ee86fdd
Author: hughhhh <hu...@gmail.com>
AuthorDate: Tue Jun 29 14:20:09 2021 -0700
change reference for invalid port to 1031
---
docs/src/pages/docs/Miscellaneous/issue_codes.mdx | 8 ++++++++
superset/errors.py | 2 +-
tests/databases/api_tests.py | 4 ++--
3 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/docs/src/pages/docs/Miscellaneous/issue_codes.mdx b/docs/src/pages/docs/Miscellaneous/issue_codes.mdx
index df8b65f..5a3b551 100644
--- a/docs/src/pages/docs/Miscellaneous/issue_codes.mdx
+++ b/docs/src/pages/docs/Miscellaneous/issue_codes.mdx
@@ -271,3 +271,11 @@ One or more parameters specified in the query are malformatted.
```
The query contains one or more malformed template parameters. Please check your query and confirm that all template parameters are surround by double braces, for example, "{{ ds }}". Then, try running your query again.
+
+## Issue 1031
+
+```
+The database port provided is invalid.
+```
+
+Please check that the provided database port is an integer between 0 and 65535 (inclusive).
diff --git a/superset/errors.py b/superset/errors.py
index 52cee12..fd0cffe 100644
--- a/superset/errors.py
+++ b/superset/errors.py
@@ -188,7 +188,7 @@ ERROR_TYPES_TO_ISSUE_CODES_MAPPING = {
{"code": 1008, "message": _("Issue 1008 - The port is closed.")},
],
SupersetErrorType.CONNECTION_INVALID_PORT_ERROR: [
- {"code": 1021, "message": _("Issue 1021 - Port number is invalid.")},
+ {"code": 1031, "message": _("Issue 1031 - Port number is invalid.")},
],
SupersetErrorType.CONNECTION_HOST_DOWN_ERROR: [
{
diff --git a/tests/databases/api_tests.py b/tests/databases/api_tests.py
index 9247a52..a61263a 100644
--- a/tests/databases/api_tests.py
+++ b/tests/databases/api_tests.py
@@ -1948,8 +1948,8 @@ class TestDatabaseApi(SupersetTestCase):
"invalid": ["port"],
"issue_codes": [
{
- "code": 1021,
- "message": "Issue 1021 - Port number is invalid.",
+ "code": 1031,
+ "message": "Issue 1031 - Port number is invalid.",
}
],
},
[superset] 01/02: Merge branch 'master' of
https://github.com/apache/superset into pexdax/db-connection-ui
Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hugh/fix-port-err-num
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 44504f592887edb3a12ca7b31469d7751e7b7e71
Merge: 2db0f25 4a394cd
Author: hughhhh <hu...@gmail.com>
AuthorDate: Tue Jun 29 14:16:46 2021 -0700
Merge branch 'master' of https://github.com/apache/superset into pexdax/db-connection-ui
.github/ISSUE_TEMPLATE/sip.md | 4 +-
CHANGELOG.md | 505 +
CONTRIBUTING.md | 2 +-
INSTALL.md | 2 +-
RELEASING/README.md | 7 +-
RELEASING/release-notes-1-2/README.md | 122 +
.../release-notes-1-2/media/dashboard_rbac.png | Bin 0 -> 554983 bytes
.../release-notes-1-2/media/native_filters.png | Bin 0 -> 392227 bytes
.../media/native_filters_temporal.png | Bin 0 -> 120672 bytes
.../release-notes-1-2/media/pivot_table_v2.png | Bin 0 -> 590341 bytes
RELEASING/release-notes-1-2/media/radar_chart.png | Bin 0 -> 222199 bytes
.../media/time_series_multichart.png | Bin 0 -> 38078 bytes
docs/installation.rst | 11 +-
.../pages/docs/Connecting to Databases/ascend.mdx | 17 +
.../pages/docs/Connecting to Databases/index.mdx | 1 +
.../docs/Creating Charts and Dashboards/index.mdx | 16 +
docs/src/pages/docs/Miscellaneous/issue_codes.mdx | 64 +
.../pages/docs/frequently-asked-questions-page.mdx | 2 +-
docs/src/pages/docs/installation/caching.mdx | 6 +-
docs/src/pages/docs/installation/configuring.mdx | 3 +-
docs/static/images/tutorial_dashboard_access.png | Bin 0 -> 46743 bytes
helm/superset/Chart.yaml | 2 +-
helm/superset/templates/deployment-worker.yaml | 3 +
helm/superset/templates/deployment.yaml | 3 +
helm/superset/values.yaml | 27 +-
requirements/base.txt | 2 +-
requirements/testing.txt | 2 -
setup.cfg | 2 +-
setup.py | 3 +-
.../integration/chart_list/card_view.test.ts | 16 +-
.../integration/chart_list/list_view.test.ts | 6 +-
.../cypress/integration/dashboard/fav_star.test.js | 22 +-
.../integration/dashboard_list/card_view.test.ts | 16 +-
.../integration/dashboard_list/list_view.test.ts | 6 +-
superset-frontend/package-lock.json | 23401 ++++++++-----------
superset-frontend/package.json | 4 +-
.../spec/fixtures/mockDashboardLayout.js | 2 +-
.../dashboard/components/FiltersBadge_spec.tsx | 99 +-
.../components/gridComponents/Divider_spec.jsx | 2 +-
.../components/gridComponents/Tabs_spec.jsx | 13 +-
.../dashboard/util/getDashboardUrl_spec.js | 45 +-
.../util/getFormDataWithExtraFilters_spec.ts | 1 +
.../datasource/DatasourceEditor_spec.jsx | 9 +-
superset-frontend/src/CRUD/CollectionTable.tsx | 2 +-
superset-frontend/src/SqlLab/reducers/sqlLab.js | 15 +-
superset-frontend/src/chart/chartAction.js | 33 +-
.../hooks/useComponentDidUpdate}/index.ts | 2 +-
.../useComponentDidUpdate.test.ts} | 36 +-
.../useComponentDidUpdate.ts} | 19 +-
superset-frontend/src/components/Alert/index.tsx | 3 +-
.../AlteredSliceTag/AlteredSliceTag.test.jsx | 4 +-
.../src/components/AnchorLink/index.jsx | 8 +-
.../src/components/CertifiedIcon/index.tsx | 7 +-
.../src/components/EditableTitle/index.tsx | 7 +
.../ErrorMessage/BasicErrorAlert.test.tsx | 14 +-
.../components/ErrorMessage/BasicErrorAlert.tsx | 11 +-
.../components/ErrorMessage/ErrorAlert.test.tsx | 14 +-
.../src/components/ErrorMessage/ErrorAlert.tsx | 34 +-
.../src/components/ErrorMessage/types.ts | 6 +
.../src/components/FaveStar/FaveStar.test.tsx | 16 +-
.../src/components/FaveStar/index.tsx | 4 +-
.../components/FilterableTable/FilterableTable.tsx | 4 +-
.../components/IconTooltip/IconTooltip.stories.tsx | 4 +-
.../src/components/ImportModal/index.tsx | 5 -
.../src/components/IndeterminateCheckbox/index.tsx | 22 +-
.../components/LastUpdated/LastUpdated.test.tsx | 2 +-
.../src/components/LastUpdated/index.tsx | 8 +-
.../src/components/Select/AntdSelect.stories.tsx | 244 -
.../src/components/Select/AntdSelect.tsx | 355 -
.../src/components/Select/Select.stories.tsx | 471 +
superset-frontend/src/components/Select/Select.tsx | 442 +
superset-frontend/src/components/Select/utils.ts | 2 +-
.../src/components/TableSelector/index.tsx | 13 +-
.../components/dataViewCommon/TableCollection.tsx | 8 +-
superset-frontend/src/components/index.ts | 2 +-
superset-frontend/src/constants.ts | 8 +
superset-frontend/src/dashboard/actions/hydrate.js | 1 +
.../CrossFilterScopingForm.test.tsx | 6 +-
.../CrossFilterScopingForm/index.tsx | 6 +-
.../DashboardBuilder/DashboardBuilder.tsx | 3 +-
.../DashboardBuilder/DashboardContainer.tsx | 11 +-
.../dashboard/components/DashboardBuilder/state.ts | 7 +-
.../dashboard/components/DashboardBuilder/utils.ts | 3 +-
.../dashboard/components/DeleteComponentButton.jsx | 6 +-
.../components/FiltersBadge/DetailsPanel/index.tsx | 14 +-
.../dashboard/components/FiltersBadge/index.tsx | 160 +-
.../dashboard/components/FiltersBadge/selectors.ts | 66 +-
.../Header/HeaderActionsDropdown/index.jsx | 27 +-
.../src/dashboard/components/Header/index.jsx | 5 +-
.../src/dashboard/components/IconButton.jsx | 63 -
.../components/IconButton.tsx} | 39 +-
.../dashboard/components/PropertiesModal/index.jsx | 1 -
.../components/SliceHeader/SliceHeader.test.tsx | 2 +-
.../src/dashboard/components/SliceHeader/index.tsx | 2 +-
.../components/SliceHeaderControls/index.tsx | 10 +-
.../components/gridComponents/ChartHolder.jsx | 36 +-
.../dashboard/components/gridComponents/Column.jsx | 30 +-
.../components/gridComponents/Markdown.jsx | 1 +
.../dashboard/components/gridComponents/Row.jsx | 26 +-
.../dashboard/components/gridComponents/Tabs.jsx | 17 +-
.../components/gridComponents/Tabs.test.tsx | 2 +-
.../dashboard/components/gridComponents/index.js | 4 +-
.../CascadeFilters/CascadeFilterControl/index.tsx | 54 +-
.../CascadeFilters/CascadePopover/index.tsx | 25 +-
.../FilterBar/FilterControls/FilterControl.tsx | 56 +-
.../FilterBar/FilterControls/FilterValue.tsx | 87 +-
.../components/nativeFilters/FilterBar/index.tsx | 31 +-
.../components/nativeFilters/FilterBar/state.ts | 16 +-
.../FiltersConfigForm/CollapsibleControl.tsx | 13 +-
.../FiltersConfigForm/ColumnSelect.tsx | 50 +-
.../FiltersConfigForm/DefaultValue.tsx | 5 +-
.../FiltersConfigForm/FilterScope/FilterScope.tsx | 85 +-
.../FiltersConfigForm/FilterScope/ScopingTree.tsx | 29 +-
.../FiltersConfigForm/FilterScope/state.ts | 16 +-
.../FiltersConfigForm/FilterScope/types.ts | 12 +-
.../FiltersConfigForm/FilterScope/utils.ts | 40 +-
.../FiltersConfigForm/FiltersConfigForm.tsx | 183 +-
.../FiltersConfigForm/getControlItemsMap.tsx | 2 +-
.../FiltersConfigModal/FiltersConfigForm/state.ts | 49 +-
.../FiltersConfigModal/FiltersConfigForm/utils.ts | 29 +
.../FiltersConfigModal/FiltersConfigModal.test.tsx | 2 +-
.../dashboard/components/nativeFilters/state.ts | 11 +
.../dashboard/components/nativeFilters/utils.ts | 1 +
.../dashboard/containers/DashboardComponent.jsx | 28 +-
.../src/dashboard/containers/DashboardHeader.jsx | 4 +
.../src/dashboard/containers/FiltersBadge.tsx | 115 -
.../src/dashboard/stylesheets/index.less | 1 -
superset-frontend/src/dashboard/types.ts | 25 +-
.../src/dashboard/util/activeDashboardFilters.js | 4 +-
.../src/dashboard/util/getDashboardUrl.ts | 36 +-
.../src/datasource/DatasourceEditor.jsx | 17 +-
.../src/explore/components/ControlHeader.jsx | 25 +-
.../explore/components/DataTablesPane/index.tsx | 4 +-
.../explore/components/DatasourcePanel/index.tsx | 43 +-
.../controls/DateFilterControl/DateFilterLabel.tsx | 25 +-
.../index.tsx | 2 +-
.../explore/components/controls/ViewQueryModal.tsx | 4 +-
.../src/explore/exploreUtils/index.js | 2 +-
.../components/GroupBy/GroupByFilterPlugin.tsx | 57 +-
.../src/filters/components/GroupBy/controlPanel.ts | 12 +
.../filters/components/Range/RangeFilterPlugin.tsx | 90 +-
.../src/filters/components/Range/controlPanel.ts | 18 +
.../components/Select/SelectFilterPlugin.tsx | 101 +-
.../src/filters/components/Select/controlPanel.ts | 3 +-
.../filters/components/Time/TimeFilterPlugin.tsx | 40 +-
.../src/filters/components/Time/controlPanel.ts | 22 +-
.../TimeColumn/TimeColumnFilterPlugin.tsx | 54 +-
.../filters/components/TimeColumn/controlPanel.ts | 22 +-
.../components/TimeGrain/TimeGrainFilterPlugin.tsx | 62 +-
.../filters/components/TimeGrain/controlPanel.ts | 22 +-
superset-frontend/src/filters/components/common.ts | 2 +-
superset-frontend/src/setup/setupColors.ts | 5 +-
superset-frontend/src/setup/setupErrorMessages.ts | 24 +
superset-frontend/src/utils/urlUtils.ts | 13 +-
.../src/views/CRUD/data/dataset/DatasetList.tsx | 2 +-
superset-frontend/webpack.config.js | 13 +-
superset/app.py | 733 +-
superset/charts/api.py | 39 +-
superset/common/query_object.py | 4 +-
superset/config.py | 41 +-
superset/connectors/base/models.py | 10 +-
superset/connectors/connector_registry.py | 62 +
superset/connectors/druid/models.py | 12 +-
superset/connectors/sqla/models.py | 26 +-
superset/dashboards/commands/importers/v0.py | 25 +-
superset/datasets/api.py | 18 +-
superset/db_engine_specs/ascend.py | 40 +
superset/db_engine_specs/base.py | 11 +-
superset/db_engine_specs/druid.py | 9 +
superset/errors.py | 70 +
superset/exceptions.py | 16 +-
superset/{app.py => initialization/__init__.py} | 111 +-
superset/models/dashboard.py | 14 +
superset/sql_lab.py | 111 +-
superset/tasks/async_queries.py | 149 +-
superset/tasks/thumbnails.py | 60 +-
superset/translations/ja/LC_MESSAGES/messages.json | 8 +-
superset/translations/ja/LC_MESSAGES/messages.po | 8 +-
superset/translations/ko/LC_MESSAGES/messages.json | 8 +-
superset/translations/ko/LC_MESSAGES/messages.po | 8 +-
superset/translations/messages.pot | 8 +-
superset/translations/sl/LC_MESSAGES/messages.json | 4501 ++++
superset/translations/sl/LC_MESSAGES/messages.po | 13575 +++++++++++
superset/typing.py | 16 +-
superset/utils/core.py | 9 +-
superset/utils/webdriver.py | 4 +-
superset/views/chart/views.py | 2 +-
superset/views/core.py | 96 +-
superset/views/sql_lab.py | 6 +-
superset/viz.py | 15 +-
tests/access_tests.py | 79 +
tests/charts/api_tests.py | 75 +-
tests/core_tests.py | 2 +-
tests/datasets/api_tests.py | 3 +
tests/db_engine_specs/ascend_tests.py | 32 +
tests/sqla_models_tests.py | 51 +-
tests/sqllab_tests.py | 180 +-
197 files changed, 32678 insertions(+), 16083 deletions(-)