You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/06 12:30:25 UTC
[GitHub] [rocketmq-apis] drpmma opened a new pull request, #66: [ISSUE #65] Add `polling_time` for ReceiveMessageRequest
drpmma opened a new pull request, #66:
URL: https://github.com/apache/rocketmq-apis/pull/66
close #65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] drpmma merged pull request #66: [ISSUE #65] Add `long_polling_timeout` for ReceiveMessageRequest
Posted by GitBox <gi...@apache.org>.
drpmma merged PR #66:
URL: https://github.com/apache/rocketmq-apis/pull/66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] aaron-ai commented on a diff in pull request #66: [ISSUE #65] Add `polling_time` for ReceiveMessageRequest
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on code in PR #66:
URL: https://github.com/apache/rocketmq-apis/pull/66#discussion_r1040918544
##########
apache/rocketmq/v2/service.proto:
##########
@@ -96,6 +96,7 @@ message ReceiveMessageRequest {
optional google.protobuf.Duration invisible_duration = 5;
// For message auto renew and clean
bool auto_renew = 6;
+ optional google.protobuf.Duration polling_time = 7;
Review Comment:
Why `optional`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] aaron-ai commented on a diff in pull request #66: [ISSUE #65] Add `polling_time` for ReceiveMessageRequest
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on code in PR #66:
URL: https://github.com/apache/rocketmq-apis/pull/66#discussion_r1040926634
##########
apache/rocketmq/v2/service.proto:
##########
@@ -96,6 +96,7 @@ message ReceiveMessageRequest {
optional google.protobuf.Duration invisible_duration = 5;
// For message auto renew and clean
bool auto_renew = 6;
+ optional google.protobuf.Duration polling_time = 7;
Review Comment:
How about keeping the same name in `Subscription#long_polling_timeout`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] drpmma commented on a diff in pull request #66: [ISSUE #65] Add `polling_time` for ReceiveMessageRequest
Posted by GitBox <gi...@apache.org>.
drpmma commented on code in PR #66:
URL: https://github.com/apache/rocketmq-apis/pull/66#discussion_r1040924915
##########
apache/rocketmq/v2/service.proto:
##########
@@ -96,6 +96,7 @@ message ReceiveMessageRequest {
optional google.protobuf.Duration invisible_duration = 5;
// For message auto renew and clean
bool auto_renew = 6;
+ optional google.protobuf.Duration polling_time = 7;
Review Comment:
It's for version compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org