[jira] [Commented] (FLINK-4449) Heartbeat Manager integration with TaskExecutor

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853991#comment-15853991 ] 

ASF GitHub Bot commented on FLINK-4449:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2791#discussion_r99583687
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java ---
    @@ -112,22 +111,29 @@ void notifySlotAvailable(
     	 * Unregisters an infoMessage listener
     	 *
     	 * @param infoMessageListenerAddress address of infoMessage listener to unregister from this resource manager
    -	 *
     	 */
     	void unRegisterInfoMessageListener(String infoMessageListenerAddress);
     
     	/**
     	 * shutdown cluster
    +	 *
     	 * @param finalStatus
     	 * @param optionalDiagnostics
     	 */
     	void shutDownCluster(final ApplicationStatus finalStatus, final String optionalDiagnostics);
     
     	/**
     	 * Gets the currently registered number of TaskManagers.
    -	 * 
    +	 *
     	 * @param leaderSessionId The leader session ID with which to address the ResourceManager.
     	 * @return The future to the number of registered TaskManagers.
     	 */
     	Future<Integer> getNumberOfRegisteredTaskManagers(UUID leaderSessionId);
    +
    +	/*
    +	 * Sends the heartbeat to resource manager from task manager
    +	 *
    +	 * @param resourceID unique id of the task manager
    +	 */
    +	void sendHeartbeatFromTaskManager(final ResourceID resourceID);
    --- End diff --
    
    clearer to name this method `heartbeatFromTaskManager` or `reportHeartbeatFromTaskManager`.


> Heartbeat Manager integration with TaskExecutor
> -----------------------------------------------
>
>                 Key: FLINK-4449
>                 URL: https://issues.apache.org/jira/browse/FLINK-4449
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: zhangjing
>            Assignee: zhangjing
>
> ResourceManager need a heartbeat manager to monitor the connections with all registered TaskExecutor.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)