You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/05 12:04:34 UTC

[GitHub] [superset] einatbar opened a new pull request #14486: feat: show max tag count in select filter

einatbar opened a new pull request #14486:
URL: https://github.com/apache/superset/pull/14486


   ### SUMMARY
   show max tag count in select filter
   resolves: #12462
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

michael-s-molina commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834635485


   One thing that we can do is sort the values presenting the selected ones first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] amitmiran137 commented on pull request #14486: feat: show max tag count in select filter

Posted by GitBox <gi...@apache.org>.

amitmiran137 commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-832886667


   The ability here is to limit the amount of items that are visible.
   Currently @einatbar  used 5 items and then the rest goes into the count 
   
   We can increase that number to what ever feels right 
   And also the select box can always be opened to see the full list 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on pull request #14486: feat: show max tag count in select filter

Posted by GitBox <gi...@apache.org>.

ktmud commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834630886


   It is possible to add a tooltip to the "+4..." pill to display all remaining items? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat edited a comment on pull request #14486: feat: show max tag count in select filter

Posted by GitBox <gi...@apache.org>.

graceguo-supercat edited a comment on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-832911419


   @einatbar  thanks for the PR. If the filter is growing taller as user typing in more values, what will happen for the filter below this one? In your example, if "Name" is on top of "Gender" filter, will it keep push "Gender" filter down?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

villebro commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834665494


   I personally LOVE this solution, and at the risk of this hiding something vital, I think it solves the much bigger problem of killing the UX by eating the whole filter tab when having lots of selected values.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] mihir174 edited a comment on pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

mihir174 edited a comment on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834794748


   I think this is an awesome solution, and that Max's list ordering suggestion improves it even further. An interactive popover on the `+x` doesn't reveal any more information than the list itself, so I don't think we need one. We could use this for all select components across the product. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] mihir174 edited a comment on pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

mihir174 edited a comment on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834794748


   I think this is an awesome solution, and that Max's list ordering suggestion improves it even further. An interactive popover on the `+x` doesn't reveal any more information than the list itself, so I don't think we need one. We could use this for all select components across the product. 
   
   i talked with @michael-s-molina , he said he will do this change in a separate PR so that the current PR is not blocked


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

villebro commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-848796588


   > Love this improvement, one extra thing that could help is to make sure that the selected values shows on top as you re-open the dropdown as per GitHub
   > 
   > <img alt="Screen Shot 2021-05-07 at 12 05 30 PM" width="420" src="https://user-images.githubusercontent.com/487433/117496940-951c1700-af2c-11eb-97a7-31aea875e854.png">
   
   I opened this PR to implement reordering of the selected values on reopening the dropdown: #14842


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on pull request #14486: feat: show max tag count in select filter

Posted by GitBox <gi...@apache.org>.

michael-s-molina commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834627609


   > one suggestion: when user click the +4 to view all, we should only show the selected values.
   
   @junlincc This has an unintended side-effect. If the user is looking to see if a value is selected and it's not, then he can't select it because it won't show.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-832802200


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14486](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (637e443) into [master](https://codecov.io/gh/apache/superset/commit/9a96dac3a75d33299a1482ef20ffd2462b2f2e66?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a96dac) will **decrease** coverage by `0.52%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 637e443 differs from pull request most recent head 95c86bb. Consider uploading reports for the commit 95c86bb to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14486/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14486      +/-   ##
   ==========================================
   - Coverage   77.63%   77.11%   -0.53%     
   ==========================================
     Files         962      952      -10     
     Lines       49156    48160     -996     
     Branches     6183     6051     -132     
   ==========================================
   - Hits        38161    37137    -1024     
   - Misses      10792    10822      +30     
   + Partials      203      201       -2     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `71.91% <ø> (-0.55%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `81.13% <ø> (+11.90%)` | :arrow_up: |
   | [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `25.00% <0.00%> (-75.00%)` | :arrow_down: |
   | [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-50.00%)` | :arrow_down: |
   | [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `64.28% <0.00%> (-35.72%)` | :arrow_down: |
   | [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `47.00% <0.00%> (-30.00%)` | :arrow_down: |
   | [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `0.00% <0.00%> (-25.81%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `53.84% <0.00%> (-22.75%)` | :arrow_down: |
   | [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `64.70% <0.00%> (-19.91%)` | :arrow_down: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.79% <0.00%> (-10.08%)` | :arrow_down: |
   | [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `80.39% <0.00%> (-9.81%)` | :arrow_down: |
   | ... and [214 more](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9a96dac...95c86bb](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina edited a comment on pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

michael-s-molina edited a comment on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834635485


   One thing that we can do is sort the values presenting the selected ones first. Maybe with a separator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] einatbar commented on pull request #14486: feat: show max tag count in select filter

Posted by GitBox <gi...@apache.org>.

einatbar commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-833446127


   @graceguo-supercat It will push "Gender" down until the user reaches the max visible tags count. If we set a low max tags count like 5, it will be pushed by 2 rows down at most, depending on values lengths I guess.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on pull request #14486: feat: show max tag count in select filter

Posted by GitBox <gi...@apache.org>.

michael-s-molina commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-833574325


   I also really like the solution. I think that when we have a lot of selected values it's difficult for the user to actually see what's selected. Generally, the user wants to know if a particular value is selected, and for that case opening the select and searching for it can be faster than trying to find it visually in the middle of 30 selected items. Another thing that bugs me is the layout flick of every item below the select. 
   
   Independently of which solution we choose, we need to keep the consistency of all selects. For example, in Explore, the selects are expanding so if we choose to use the tag count here, we should also apply the same pattern there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #14486: feat: show max tag count in select filter

Posted by GitBox <gi...@apache.org>.

junlincc commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-832872761


   thanks for the PR! I personally love the solution. @amitmiran137 
   However, we want to offer the transparency to show dashboard consumer what filter values are selected at a glance. 
   The problem is that the list could get long and take up lots of space. My proposed solution is to offer the option to collapse/minimize the select box, to 2 lines maybe?  
   
   @graceguo-supercat @mihir174 @ktmud wdyt? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

rusackas commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834654966

> > It is possible to add a tooltip to the "+4..." pill to display all remaining items?
>
> @ktmud I liked the idea. If we have few values it's easy to check the remaining items. If we have a bunch of values the user can click on the select and search for a specific value.

It seems that where this gets difficult is not when we're in a `+4` situation, but when we're in a `+104` situation.

For _most_ use cases, I'd bet the select menu isn't absurdly long, and the list of checked/selected items isn't absurdly long either. In that case, clicking the `+𝒙` and popping open the select menu to view/add/remove items from the selection seems perfectly acceptable.

However, with LOTS of selections from LOTS of options (let's say, cities in the US... and you've selected 90 of them) then we have a bigger problem. For _that_ I see multiple potential approaches:

1) When you click the `+𝒙` it opens the select menu, with two new features:
• Selected items at the top
• A search input to find a specific option to (de)select
• A tooltip on the `+𝒙` to show a lightweight list of items contained therein

2) Leave the select menu as-is (maybe add the search anyway), but add an interactive popover to the `+𝒙` item.
• Popover would contain the remaining list of selected values.
• Each value in that list would have a little 🅧 button next to it to remove the selection, just like the other tag/label selections that precede the `+𝒙`

3) Both?

Not sure if this makes sense - happy to draw up wireframes if it helps explain (perhaps with @mihir174)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat commented on pull request #14486: feat: show max tag count in select filter

Posted by GitBox <gi...@apache.org>.

graceguo-supercat commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-832911419


   @einatbar  thanks for the PR. If the filter is growing taller when as user typing in more values, what will happen for the filter below this one? In your example, if "Name" is on top of "Gender" filter, will it keep push "Gender" filter down?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

michael-s-molina commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834634433


   > @michael-s-molina is the purpose of expanding to view all selected values or to edit select? User can certainly click the empty space to edit the select
   
   Both. The AntD team decided to use this default behavior because it's important to the user to view which values are selected and also which ones are not, and to quickly be able to select/unselect a value. Most of the time the user is looking to see if a specific value is selected, and not to read through all the values. Personally, I would stick to the default behavior proposed by AntD.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] mihir174 commented on pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

mihir174 commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834794748


   I think this is an awesome solution, and that Max's list ordering suggestion improves it even further. An interactive popover on the `+x` doesn't reveal any more information that the list itself, so I don't think we need one. We could use this for all select components across the product. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] mistercrunch commented on pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

mistercrunch commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834706507


   Love this improvement, one extra thing that could help is to make sure that the selected values shows on top as you re-open the dropdown as per GitHub
   
   <img width="420" alt="Screen Shot 2021-05-07 at 12 05 30 PM" src="https://user-images.githubusercontent.com/487433/117496940-951c1700-af2c-11eb-97a7-31aea875e854.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina edited a comment on pull request #14486: feat: show max tag count in select filter

Posted by GitBox <gi...@apache.org>.

michael-s-molina edited a comment on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834627609


   > when user click "+10...." to view all, we should only show the selected values in the dropdown, instead of scrolling to look for all that have been selected
   
   @junlincc This has an unintended side-effect. If the user is looking to see if a value is selected and it's not, then he can't select it because it won't show.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #14486: feat: show max tag count in select filter

Posted by GitBox <gi...@apache.org>.

codecov[bot] commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-832802200


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14486](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (637e443) into [master](https://codecov.io/gh/apache/superset/commit/5aef6bccd1844bf2f318fef3d7abaefbc326e78a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5aef6bc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14486/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14486      +/-   ##
   ==========================================
   - Coverage   77.11%   77.11%   -0.01%     
   ==========================================
     Files         952      952              
     Lines       48159    48160       +1     
     Branches     6050     6051       +1     
   ==========================================
     Hits        37137    37137              
   - Misses      10821    10822       +1     
     Partials      201      201              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `71.91% <ø> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `81.13% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `52.70% <0.00%> (-0.27%)` | :arrow_down: |
   | [...uperset-frontend/src/explore/exploreUtils/index.js](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzL2luZGV4Lmpz) | `66.25% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5aef6bc...637e443](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] amitmiran137 commented on pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

amitmiran137 commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-848438049


   are there any mixed feelings here on merging this and do follow-ups PR's?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] amitmiran137 merged pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

amitmiran137 merged pull request #14486:
URL: https://github.com/apache/superset/pull/14486


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc edited a comment on pull request #14486: feat: show max tag count in select filter

Posted by GitBox <gi...@apache.org>.

junlincc edited a comment on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834625788


   one suggestion: when user click  "+10...."  to view all, we should only show the selected values in the dropdown. Scroll to look for all that have been selected 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #14486: feat: show max tag count in select filter

Posted by GitBox <gi...@apache.org>.

junlincc commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834625788


   one suggestion: when user click the +4 to view all, we should only show the selected values. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

michael-s-molina commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834642415


   > It is possible to add a tooltip to the "+4..." pill to display all remaining items?
   
   @ktmud I liked the idea. If we have few values it's easy to check the remaining items. If we have a bunch of values the user can click on the select and search for a specific value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc edited a comment on pull request #14486: feat: show max tag count in select filter

Posted by GitBox <gi...@apache.org>.

junlincc edited a comment on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834625788


   1) when user click  "+10...."  to view all, we should only show the selected values in the dropdown, instead of scrolling to look for all that have been selected 
   2) apply the full solution to Explore select 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] amitmiran137 commented on pull request #14486: feat: show max tag count in select filter

Posted by GitBox <gi...@apache.org>.

amitmiran137 commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-832887978


   We used the out of the box feature bin antD
   No collapse/expand ability in the select 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-832802200


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14486](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95c86bb) into [master](https://codecov.io/gh/apache/superset/commit/9a96dac3a75d33299a1482ef20ffd2462b2f2e66?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a96dac) will **decrease** coverage by `0.33%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14486/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14486      +/-   ##
   ==========================================
   - Coverage   77.63%   77.29%   -0.34%     
   ==========================================
     Files         962      961       -1     
     Lines       49156    48757     -399     
     Branches     6183     6181       -2     
   ==========================================
   - Hits        38161    37688     -473     
   - Misses      10792    10867      +75     
   + Partials      203      202       -1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `72.44% <ø> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `64.86% <ø> (-4.37%)` | :arrow_down: |
   | [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `0.00% <0.00%> (-25.81%)` | :arrow_down: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.79% <0.00%> (-10.08%)` | :arrow_down: |
   | [superset/utils/screenshots.py](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | `38.59% <0.00%> (-9.65%)` | :arrow_down: |
   | [superset/views/tags.py](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `40.74% <0.00%> (-9.26%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `81.37% <0.00%> (-6.31%)` | :arrow_down: |
   | [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `59.68% <0.00%> (-4.81%)` | :arrow_down: |
   | [superset/tasks/async\_queries.py](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvYXN5bmNfcXVlcmllcy5weQ==) | `92.30% <0.00%> (-4.71%)` | :arrow_down: |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.67% <0.00%> (-4.64%)` | :arrow_down: |
   | ... and [52 more](https://codecov.io/gh/apache/superset/pull/14486/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9a96dac...95c86bb](https://codecov.io/gh/apache/superset/pull/14486?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on pull request #14486: feat(native-filter): limit max tag count for selected filter values

Posted by GitBox <gi...@apache.org>.

rusackas commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834657034


   I think one thing important to mention (although perhaps tangential to the UI discussion) is that we get to the point where we have _one_ select component we use everywhere in Superset, with whatever props/interfaces/styling we need to achieve all these goals. I _suspect_ the AntD component will suffice and we can replace `react-select` component. Anyway, back to the topic at hand... 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #14486: feat: show max tag count in select filter

Posted by GitBox <gi...@apache.org>.

junlincc commented on pull request #14486:
URL: https://github.com/apache/superset/pull/14486#issuecomment-834629042


   @michael-s-molina is the purpose of expanding to view all selected values or to edit select? User can certainly click the empty space to edit the select


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org