You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Saisai Shao <sa...@gmail.com> on 2015/11/11 06:36:03 UTC
Review Request 40176: Bump Spark definition to 1.5.2 in Ambari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40176/
-----------------------------------------------------------
Review request for Ambari and Sumit Mohanty.
Repository: ambari
Description
-------
Bump Spark definition to 1.5.2 in Ambari
Diffs
-----
ambari-server/src/main/resources/common-services/SPARK/1.5.1.2.3/metainfo.xml 190d892
ambari-server/src/main/resources/common-services/SPARK/1.5.2.2.3/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml 0e20794
Diff: https://reviews.apache.org/r/40176/diff/
Testing
-------
Local test is done.
Thanks,
Saisai Shao
Re: Review Request 40176: Bump Spark definition to 1.5.2 in Ambari
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On Nov. 13, 2015, 2:33 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml, line 26
> > <https://reviews.apache.org/r/40176/diff/1/?file=1122910#file1122910line26>
> >
> > All you need is this line to be changed.
> >
> > You can just delete ambari-server/src/main/resources/common-services/SPARK/1.5.1.2.3/metainfo.xml. No need to add the other file. Its not getting used.
>
> Saisai Shao wrote:
> Hi Sumit, I think I've deleted "ambari-server/src/main/resources/common-services/SPARK/1.5.1.2.3/metainfo.xml" and changed to "ambari-server/src/main/resources/common-services/SPARK/1.5.2.2.3/metainfo.xml". You mean this xxx/1.5.2.2.3/metainfo.xml is also not needed?
>> You mean this xxx/1.5.2.2.3/metainfo.xml is also not needed?
Yes, lets delete this file as well
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40176/#review106416
-----------------------------------------------------------
On Nov. 11, 2015, 5:36 a.m., Saisai Shao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40176/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 5:36 a.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Bump Spark definition to 1.5.2 in Ambari
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/SPARK/1.5.1.2.3/metainfo.xml 190d892
> ambari-server/src/main/resources/common-services/SPARK/1.5.2.2.3/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml 0e20794
>
> Diff: https://reviews.apache.org/r/40176/diff/
>
>
> Testing
> -------
>
> Local test is done.
>
>
> Thanks,
>
> Saisai Shao
>
>
Re: Review Request 40176: Bump Spark definition to 1.5.2 in Ambari
Posted by Saisai Shao <sa...@gmail.com>.
> On Nov. 13, 2015, 2:33 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml, line 26
> > <https://reviews.apache.org/r/40176/diff/1/?file=1122910#file1122910line26>
> >
> > All you need is this line to be changed.
> >
> > You can just delete ambari-server/src/main/resources/common-services/SPARK/1.5.1.2.3/metainfo.xml. No need to add the other file. Its not getting used.
Hi Sumit, I think I've deleted "ambari-server/src/main/resources/common-services/SPARK/1.5.1.2.3/metainfo.xml" and changed to "ambari-server/src/main/resources/common-services/SPARK/1.5.2.2.3/metainfo.xml". You mean this xxx/1.5.2.2.3/metainfo.xml is also not needed?
- Saisai
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40176/#review106416
-----------------------------------------------------------
On Nov. 11, 2015, 5:36 a.m., Saisai Shao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40176/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 5:36 a.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Bump Spark definition to 1.5.2 in Ambari
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/SPARK/1.5.1.2.3/metainfo.xml 190d892
> ambari-server/src/main/resources/common-services/SPARK/1.5.2.2.3/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml 0e20794
>
> Diff: https://reviews.apache.org/r/40176/diff/
>
>
> Testing
> -------
>
> Local test is done.
>
>
> Thanks,
>
> Saisai Shao
>
>
Re: Review Request 40176: Bump Spark definition to 1.5.2 in Ambari
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40176/#review106416
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml (line 26)
<https://reviews.apache.org/r/40176/#comment165154>
All you need is this line to be changed.
You can just delete ambari-server/src/main/resources/common-services/SPARK/1.5.1.2.3/metainfo.xml. No need to add the other file. Its not getting used.
- Sumit Mohanty
On Nov. 11, 2015, 5:36 a.m., Saisai Shao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40176/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 5:36 a.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Bump Spark definition to 1.5.2 in Ambari
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/SPARK/1.5.1.2.3/metainfo.xml 190d892
> ambari-server/src/main/resources/common-services/SPARK/1.5.2.2.3/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml 0e20794
>
> Diff: https://reviews.apache.org/r/40176/diff/
>
>
> Testing
> -------
>
> Local test is done.
>
>
> Thanks,
>
> Saisai Shao
>
>
Re: Review Request 40176: Bump Spark definition to 1.5.2 in Ambari
Posted by Saisai Shao <sa...@gmail.com>.
> On Nov. 16, 2015, 1:20 a.m., Sumit Mohanty wrote:
> > I will remove the file as part of commit.
Thanks a lot!
- Saisai
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40176/#review106585
-----------------------------------------------------------
On Nov. 11, 2015, 5:36 a.m., Saisai Shao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40176/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 5:36 a.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Bump Spark definition to 1.5.2 in Ambari
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/SPARK/1.5.1.2.3/metainfo.xml 190d892
> ambari-server/src/main/resources/common-services/SPARK/1.5.2.2.3/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml 0e20794
>
> Diff: https://reviews.apache.org/r/40176/diff/
>
>
> Testing
> -------
>
> Local test is done.
>
>
> Thanks,
>
> Saisai Shao
>
>
Re: Review Request 40176: Bump Spark definition to 1.5.2 in Ambari
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40176/#review106585
-----------------------------------------------------------
Ship it!
I will remove the file as part of commit.
- Sumit Mohanty
On Nov. 11, 2015, 5:36 a.m., Saisai Shao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40176/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 5:36 a.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Bump Spark definition to 1.5.2 in Ambari
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/SPARK/1.5.1.2.3/metainfo.xml 190d892
> ambari-server/src/main/resources/common-services/SPARK/1.5.2.2.3/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml 0e20794
>
> Diff: https://reviews.apache.org/r/40176/diff/
>
>
> Testing
> -------
>
> Local test is done.
>
>
> Thanks,
>
> Saisai Shao
>
>
Re: Review Request 40176: Bump Spark definition to 1.5.2 in Ambari
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40176/#review106017
-----------------------------------------------------------
Ship it!
Ship It!
- Matt
On Nov. 10, 2015, 9:36 p.m., Saisai Shao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40176/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 9:36 p.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Bump Spark definition to 1.5.2 in Ambari
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/SPARK/1.5.1.2.3/metainfo.xml 190d892
> ambari-server/src/main/resources/common-services/SPARK/1.5.2.2.3/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml 0e20794
>
> Diff: https://reviews.apache.org/r/40176/diff/
>
>
> Testing
> -------
>
> Local test is done.
>
>
> Thanks,
>
> Saisai Shao
>
>