[GitHub] [inlong] healchow commented on a diff in pull request #6046: [INLONG-6044][Manager] Distinguish between group and stream configuration processes

[GitBox <gi...@apache.org>]

healchow commented on code in PR #6046:
URL: https://github.com/apache/inlong/pull/6046#discussion_r993346660


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/group/DeleteGroupWorkflowDefinition.java:
##########
@@ -85,22 +77,12 @@ public WorkflowProcess defineProcess() {
         deleteMQTask.setListenerFactory(groupTaskListenerFactory);
         process.addTask(deleteMQTask);
 
-        // Delete Sort

Review Comment:
   When do we need to delete the Sort task?
   
   As far as I know, a Sort task may process data of multiple Pairs<StreamSource, StreamSink>. To modify any StreamSource or StreamSink, we stop the Sort task first, push all updated and non-updated StreamSource or StreamSink information to the Sort task, and finally restart it.
   
   In this case, how to maintain the Sort task?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org