You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "btlqql (via GitHub)" <gi...@apache.org> on 2026/08/21 10:43:26 UTC
[PR] fix(metrics): render native histogram samples in Metrics Explorer [rocketmq-dashboard]
btlqql opened a new pull request, #2519:
URL: https://github.com/apache/rocketmq-dashboard/pull/2519
## What is the purpose of the change
The Metrics Explorer chart only read `series.values`, so a PromQL query that returned native histograms (no scalar samples) was plotted as the empty state even though data existed.
## Brief changelog
- `toNumericSamples` now falls back to the series' histogram samples when no scalar values are present
- each histogram contributes a trend point: the observed `sum` in the metric's unit, falling back to the observation `count` when the sum is blank or non-finite (a blank field parses to `0`, so it is treated as missing)
- scalar samples still take precedence when both are present
- series drawn from histograms are marked with a "Histogram" tag in the legend, and the empty-state copy now reads "No samples" / "暂无数据"
## How was this patch verified
- web: `MetricsExplorer.test.tsx` 15/15 (histogram-only renders from sums, blank sum falls back to count, scalar-over-histogram precedence, empty state); full `vitest run` 642/642; `tsc -b` and `eslint` clean
Fixes #2492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metrics): render native histogram samples in Metrics Explorer [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2519:
URL: https://github.com/apache/rocketmq-dashboard/pull/2519#issuecomment-5379382364
Integrated into #2516 (merged as part of the same-author consolidation batch, preserving original authorship). Thanks for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metrics): render native histogram samples in Metrics Explorer [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2519: fix(metrics): render native histogram samples in Metrics Explorer
URL: https://github.com/apache/rocketmq-dashboard/pull/2519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org