You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/14 01:45:19 UTC

Review Request 24678: Fixed the flaky SlaveRecoveryTest.ShutdownSlave.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24678/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/tests/slave_recovery_tests.cpp b53353c7c557244ec4a673a7f8ed13c94bad1584 

Diff: https://reviews.apache.org/r/24678/diff/


Testing
-------

make check
bin/mesos-tests.sh --gtest_filter=*ShutdownSlave --gtest_repeat=20


Thanks,

Jie Yu

Re: Review Request 24678: Fixed the flaky SlaveRecoveryTest.ShutdownSlave.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24678/#review50529
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Aug. 13, 2014, 11:45 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24678/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 11:45 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp b53353c7c557244ec4a673a7f8ed13c94bad1584 
> 
> Diff: https://reviews.apache.org/r/24678/diff/
> 
> 
> Testing
> -------
> 
> make check
> bin/mesos-tests.sh --gtest_filter=*ShutdownSlave --gtest_repeat=20
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24678: Fixed the flaky SlaveRecoveryTest.ShutdownSlave.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24678/#review50552
-----------------------------------------------------------


Patch looks great!

Reviews applied: [24678]

All tests passed.

- Mesos ReviewBot


On Aug. 13, 2014, 11:45 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24678/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 11:45 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp b53353c7c557244ec4a673a7f8ed13c94bad1584 
> 
> Diff: https://reviews.apache.org/r/24678/diff/
> 
> 
> Testing
> -------
> 
> make check
> bin/mesos-tests.sh --gtest_filter=*ShutdownSlave --gtest_repeat=20
> 
> 
> Thanks,
> 
> Jie Yu
> 
>