[kafka] branch trunk updated: MINOR: Use Exit.addShutdownHook instead of directly adding hooks to Runtime (#12283)

[mi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

mimaison pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 4426b05e54 MINOR: Use Exit.addShutdownHook instead of directly adding hooks to Runtime (#12283)
4426b05e54 is described below

commit 4426b05e549e97c9d1f544083f4dcb71e109b819
Author: Divij Vaidya <di...@amazon.com>
AuthorDate: Mon Jun 13 17:25:40 2022 +0200

    MINOR: Use Exit.addShutdownHook instead of directly adding hooks to Runtime (#12283)
    
    
    Reviewers: Mickael Maison <mi...@gmail.com>, Igor Soarez  <so...@apple.com>, Kvicii <kv...@gmail.com>
---
 .../main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java b/server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java
index e4b7afc3ea..329083350c 100644
--- a/server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java
+++ b/server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java
@@ -22,6 +22,7 @@ import com.yammer.metrics.core.MetricsRegistry;
 import org.apache.kafka.common.Reconfigurable;
 import org.apache.kafka.common.config.ConfigException;
 import org.apache.kafka.common.metrics.JmxReporter;
+import org.apache.kafka.common.utils.Exit;
 import org.apache.kafka.common.utils.Sanitizer;
 
 import java.util.Iterator;
@@ -57,7 +58,7 @@ public class KafkaYammerMetrics implements Reconfigurable {
 
     private KafkaYammerMetrics() {
         jmxReporter.start();
-        Runtime.getRuntime().addShutdownHook(new Thread(jmxReporter::shutdown));
+        Exit.addShutdownHook("kafka-jmx-shutdown-hook", jmxReporter::shutdown);
     }
 
     @Override