You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2022/01/08 23:46:16 UTC
[orc] branch branch-1.6 updated: ORC-875: Add GitHub Action job for Windows Server 2019 (#999)
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-1.6
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/branch-1.6 by this push:
new 2cc6f2a ORC-875: Add GitHub Action job for Windows Server 2019 (#999)
2cc6f2a is described below
commit 2cc6f2a42f62ca273b3ad44bfa226620a2699eee
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Sat Jan 8 15:46:12 2022 -0800
ORC-875: Add GitHub Action job for Windows Server 2019 (#999)
### What changes were proposed in this pull request?
This PR aims to add a test coverage for Windows on GitHub Action additionally.
### Why are the changes needed?
This PR aims to replace `AppVeyor` with GitHub Action eventually.
**AS IS(AppVeyor)**
https://github.com/apache/orc/blob/ae660f3006cae145d0db7a897fd81fe94029c0b2/appveyor.yml#L18-L41
**THIS PR(GitHub Action)**
https://github.com/apache/orc/runs/4662857757?check_suite_focus=true
```
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe - skipped
-- compiler MSVC version 19.0.24245.0
...
Test project D:/a/orc/orc/build
Start 1: orc-test
1/1 Test #1: orc-test ......................... Passed 61.99 sec
```
### How was this patch tested?
Pass the GitHub Action with newly add Windows job.
(cherry picked from commit 2b62dc32a4d57a0df4015cc1f7c465c17ad392d6)
Signed-off-by: Dongjoon Hyun <do...@apache.org>
(cherry picked from commit b1b0fedd9edcb8e7f44a9694223977762facdb52)
Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
.github/workflows/build_and_test.yml | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml
index dbdc774..174309b 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -47,6 +47,22 @@ jobs:
mvn apache-rat:check
mvn checkstyle:check
+ windows:
+ name: "Build on Windows"
+ runs-on: windows-2019
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v2
+ - name: Add msbuild to PATH
+ uses: microsoft/setup-msbuild@v1.1
+ - name: "Test"
+ run: |
+ mkdir build
+ cd build
+ cmake .. -G "Visual Studio 14 2015 Win64" -DCMAKE_BUILD_TYPE=Debug -DBUILD_LIBHDFSPP=OFF -DBUILD_TOOLS=OFF -DBUILD_JAVA=OFF
+ cmake --build . --config Debug
+ ctest -C Debug
+
doc:
name: "Javadoc generation"
runs-on: ubuntu-20.04