Re: [PR] Additional outstanding issues for grails-shell-cli [grails-core]

["jdaugherty (via GitHub)" <gi...@apache.org>]

jdaugherty commented on code in PR #14708:
URL: https://github.com/apache/grails-core/pull/14708#discussion_r2072286767


##########
gradle/assemble-config.gradle:
##########
@@ -19,13 +19,14 @@
 
 tasks.register('installToHomeDist').configure { Task task ->
     task.inputs.files(tasks.named('jar'))
-    task.inputs.files(tasks.named('sourcesJar'))
-    task.inputs.files(tasks.named('javadocJar'))
     task.outputs.dir(distInstallDir)
 
     doLast {
         copy {
-            it.from layout.buildDirectory.dir('libs')
+            it.from layout.buildDirectory.dir('libs').map { it.asFileTree.matching {

Review Comment:
   Was there more than jar files being copied?  Why not add the exclude at the high level so you don't have to iterate over all of the files? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org