You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/09 07:32:03 UTC

[GitHub] [flink] wuchong commented on issue #11339: CodeGenUtils generates code that has two semicolons for GroupingWindowAggsHandler in blink

wuchong commented on issue #11339: CodeGenUtils generates code that has two semicolons for GroupingWindowAggsHandler in blink
URL: https://github.com/apache/flink/pull/11339#issuecomment-596371272
 
 
   Hi @hehuiyuan , thanks for the contribution. The code looks good to me. 
   However, please follow the [contribution guideline](https://flink.apache.org/contributing/contribute-code.html) that the title should have issue id and component name, e.g. `[FLINK-16463][table-planner-blink] CodeGenUtils...`. Besides, the commit message should also follow this rule.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services