[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2165: Spark: Extend write distribution and ordering with more options

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #2165:
URL: https://github.com/apache/iceberg/pull/2165#discussion_r565707394



##########
File path: spark3-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4
##########
@@ -69,7 +69,18 @@ statement
     : CALL multipartIdentifier '(' (callArgument (',' callArgument)*)? ')'                  #call
     | ALTER TABLE multipartIdentifier ADD PARTITION FIELD transform (AS name=identifier)?   #addPartitionField
     | ALTER TABLE multipartIdentifier DROP PARTITION FIELD transform                        #dropPartitionField
-    | ALTER TABLE multipartIdentifier WRITE ORDERED BY order                                #setTableOrder
+    | ALTER TABLE multipartIdentifier WRITE
+        writeDistributionSpec?

Review comment:
       I decided to allow such calls:
   
   ```
   ALTER TABLE t WRITE
   DISTRIBUTED BY PARTITION
   UNORDERED
   ```
   
   or
   
   ```
   ALTER TABLE t WRITE
   DISTRIBUTED BY PARTITION
   UNORDERED
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org