You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ddna1021 <gi...@git.apache.org> on 2018/01/10 12:13:33 UTC
[GitHub] spark pull request #20220: Update PageRank.scala
GitHub user ddna1021 opened a pull request:
https://github.com/apache/spark/pull/20220
Update PageRank.scala
## What changes were proposed in this pull request?
Hi, acording to code below,
"if (id == src) (0.0, Double.NegativeInfinity) else (0.0, 0.0)"
I think the comment can be wrong
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ddna1021/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20220.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20220
----
commit 181727e37952c67f543cf5cd18e1acbe31e3a3e8
Author: FanDonglai <dd...@...>
Date: 2018-01-10T12:10:27Z
Update PageRank.scala
Acording to code below,
"if (id == src) (0.0, Double.NegativeInfinity) else (0.0, 0.0)"
I think the comment can be wrong
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20220: Update PageRank.scala
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20220
Merged to master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20220: Update PageRank.scala
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20220
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20220: Update PageRank.scala
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20220
Yeah I figured it's minor enough we can go ahead and not bother back-porting to 2.3. I don't mind anyone else backporting.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20220: Update PageRank.scala
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20220
**[Test build #4034 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4034/testReport)** for PR 20220 at commit [`181727e`](https://github.com/apache/spark/commit/181727e37952c67f543cf5cd18e1acbe31e3a3e8).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20220: Update PageRank.scala
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20220
Hi, @srowen .
Is this the first Spark 2.4-only commit?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20220: Update PageRank.scala
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20220
**[Test build #4034 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4034/testReport)** for PR 20220 at commit [`181727e`](https://github.com/apache/spark/commit/181727e37952c67f543cf5cd18e1acbe31e3a3e8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20220: Update PageRank.scala
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20220
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20220: Update PageRank.scala
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20220
I think that's right; @aray this might have been missed in https://github.com/apache/spark/pull/16483
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org