You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "ifesdjeen (via GitHub)" <gi...@apache.org> on 2025/01/22 20:19:23 UTC
[PR] Avoid double loading in Cassandra side of journal [cassandra-accord]
ifesdjeen opened a new pull request, #159:
URL: https://github.com/apache/cassandra-accord/pull/159
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Avoid double loading in Cassandra side of journal [cassandra-accord]
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith commented on code in PR #159:
URL: https://github.com/apache/cassandra-accord/pull/159#discussion_r1939184815
##########
accord-core/src/main/java/accord/impl/CommandChange.java:
##########
@@ -414,6 +415,8 @@ private static Command.Truncated truncated(TxnId txnId, SaveStatus status, Statu
case TruncatedApplyWithOutcome:
case TruncatedApplyWithDeps:
case TruncatedApply:
+ if (status != TruncatedApplyWithOutcome)
Review Comment:
Would be good to mention the reason this arises. Unfortunately I've forgotten since we spoke, I think it may be because of compaction? Because if we write out a truncate record to the log it should null out this field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Avoid double loading in Cassandra side of journal [cassandra-accord]
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith commented on code in PR #159:
URL: https://github.com/apache/cassandra-accord/pull/159#discussion_r1925960606
##########
accord-core/src/main/java/accord/impl/CommandChange.java:
##########
@@ -414,6 +415,8 @@ private static Command.Truncated truncated(TxnId txnId, SaveStatus status, Statu
case TruncatedApplyWithOutcome:
case TruncatedApplyWithDeps:
case TruncatedApply:
+ if (status != TruncatedApplyWithOutcome)
Review Comment:
Can we add a TODO to tidy this up when we have a better solution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Avoid double loading in Cassandra side of journal [cassandra-accord]
Posted by "ifesdjeen (via GitHub)" <gi...@apache.org>.
ifesdjeen commented on code in PR #159:
URL: https://github.com/apache/cassandra-accord/pull/159#discussion_r1939799710
##########
accord-core/src/main/java/accord/impl/CommandChange.java:
##########
@@ -414,6 +415,8 @@ private static Command.Truncated truncated(TxnId txnId, SaveStatus status, Statu
case TruncatedApplyWithOutcome:
case TruncatedApplyWithDeps:
case TruncatedApply:
+ if (status != TruncatedApplyWithOutcome)
Review Comment:
Reverted for now; I'm sure it'll show up in burn test. When it does, we will document and/or fix it, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Avoid double loading in Cassandra side of journal [cassandra-accord]
Posted by "ifesdjeen (via GitHub)" <gi...@apache.org>.
ifesdjeen closed pull request #159: Avoid double loading in Cassandra side of journal
URL: https://github.com/apache/cassandra-accord/pull/159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org