You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/01 14:19:11 UTC
[GitHub] [spark] gengliangwang opened a new pull request #32732: [Minor][TESTS] Move Set command related test cases to a single test suite
gengliangwang opened a new pull request #32732:
URL: https://github.com/apache/spark/pull/32732
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Move `Set` command related test cases from `SQLQuerySuite` to a new test suite `SetSuite`. There are 7 test cases in total.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Code refactoring. `SQLQuerySuite` is becoming big.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32732: [SPARK-35600][TESTS] Move Set command related test cases to SetCommandSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852329988
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43693/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32732: [SPARK-35600][TESTS] Move Set command related test cases to SetCommandSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852316730
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43693/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32732: [SPARK-35600][TESTS] Move Set command related test cases to SetCommandSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852439927
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139174/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32732: [Minor][TESTS] Move Set command related test cases to a single test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852199270
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139166/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32732: [Minor][TESTS] Move Set command related test cases to a single test suite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852228686
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43686/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32732: [SPARK-35600][TESTS] Move Set command related test cases to SetCommandSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852329988
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43693/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #32732: [SPARK-35600][TESTS] Move Set command related test cases to a single test suite
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #32732:
URL: https://github.com/apache/spark/pull/32732#discussion_r643291857
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SetSuite.scala
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.test.{SharedSparkSession, TestSQLContext}
+import org.apache.spark.util.ResetSystemProperties
+
+class SetSuite extends QueryTest with SharedSparkSession with ResetSystemProperties {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32732: [SPARK-35600][TESTS] Move Set command related test cases to a single test suite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852276757
Retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32732: [Minor][TESTS] Move Set command related test cases to a single test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852199270
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139166/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32732: [SPARK-35600][TESTS] Move Set command related test cases to SetCommandSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852438804
**[Test build #139174 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139174/testReport)** for PR 32732 at commit [`97d8107`](https://github.com/apache/spark/commit/97d81073057fd325e5413097af060739f4773911).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class SetCommandSuite extends QueryTest with SharedSparkSession with ResetSystemProperties `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32732: [SPARK-35600][TESTS] Move Set command related test cases to a single test suite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852280846
Thank you for update, @gengliangwang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32732: [Minor][TESTS] Move Set command related test cases to a single test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852238336
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43686/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32732: [Minor][TESTS] Move Set command related test cases to a single test suite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852199208
**[Test build #139166 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139166/testReport)** for PR 32732 at commit [`3430609`](https://github.com/apache/spark/commit/343060997f42513472928253d8c96a7c8eacb43f).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class SetSuite extends QueryTest with SharedSparkSession with ResetSystemProperties `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32732: [SPARK-35600][TESTS] Move Set command related test cases to SetCommandSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852286806
**[Test build #139174 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139174/testReport)** for PR 32732 at commit [`97d8107`](https://github.com/apache/spark/commit/97d81073057fd325e5413097af060739f4773911).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32732: [SPARK-35600][TESTS] Move Set command related test cases to SetCommandSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852643420
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32732: [SPARK-35600][TESTS] Move Set command related test cases to SetCommandSuite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852286806
**[Test build #139174 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139174/testReport)** for PR 32732 at commit [`97d8107`](https://github.com/apache/spark/commit/97d81073057fd325e5413097af060739f4773911).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32732: [Minor][TESTS] Move Set command related test cases to a single test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852238336
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43686/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32732: [Minor][TESTS] Move Set command related test cases to a single test suite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852194169
**[Test build #139166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139166/testReport)** for PR 32732 at commit [`3430609`](https://github.com/apache/spark/commit/343060997f42513472928253d8c96a7c8eacb43f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32732: [Minor][TESTS] Move Set command related test cases to a single test suite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32732:
URL: https://github.com/apache/spark/pull/32732#discussion_r643283120
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SetSuite.scala
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.test.{SharedSparkSession, TestSQLContext}
+import org.apache.spark.util.ResetSystemProperties
+
+class SetSuite extends QueryTest with SharedSparkSession with ResetSystemProperties {
Review comment:
Maybe, `SetSuite` -> `SetCommandSuite`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32732: [Minor][TESTS] Move Set command related test cases to a single test suite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852194169
**[Test build #139166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139166/testReport)** for PR 32732 at commit [`3430609`](https://github.com/apache/spark/commit/343060997f42513472928253d8c96a7c8eacb43f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32732: [SPARK-35600][TESTS] Move Set command related test cases to SetCommandSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32732:
URL: https://github.com/apache/spark/pull/32732#issuecomment-852439927
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139174/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32732: [SPARK-35600][TESTS] Move Set command related test cases to SetCommandSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32732:
URL: https://github.com/apache/spark/pull/32732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org