You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by squito <gi...@git.apache.org> on 2017/10/27 22:18:07 UTC

[GitHub] spark pull request #19583: [WIP][SPARK-22339] [CORE] [NETWORK-SHUFFLE] Push ...

Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19583#discussion_r147526524
  
    --- Diff: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala ---
    @@ -225,6 +270,7 @@ class HeartbeatReceiverSuite
             Matchers.eq(Array(1L -> metrics.accumulators())),
             Matchers.eq(blockManagerId))
         }
    +    expectedUpdatedEpoch.foreach{_ => assert(response.updatedEpoch === expectedUpdatedEpoch)}
    --- End diff --
    
    don't you want to do this assert even if the expectedUpdate is `None`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org