You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/02/28 09:54:58 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request #6046: New feature: Reserve and release Public IPs
weizhouapache opened a new pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046
### Description
This PR provides a new feature to reserve public IPs and release them.
(1) new Public IP state: Reserved
(2) new API: reserveipaddress and releaseipaddress
(3) Reserved IP cannot be allocated to network/vms. they are considered in resource count calculation.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1064981105
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1065437634
<b>Trillian test result (tid-3577)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32165 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6046-t3577-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1070285211
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1064965351
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1064087930
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1070283176
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1069018611
Code LGTM. Small points:
- When reserving an IP for an account, it would be nice, if the account for which the IP has been reserved has the ability to release the address
- For a reserved IP address - it would be better if we could hide the Firewall, LB and protforwarding tab - this isn't major, can be addressed later too.
Thanks @weizhouapache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1063893448
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1071077306
Thanks @weizhouapache - LGTM.
Tested as root admin, domain admin and user.
Tested by reserving IP as a root admin for a domain admin and user and logged in as the user whom the IP was reserved for and was able to release the IP
Was able to reserve an IP to a project as well and logged into the project and released it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1057303075
<b>Trillian test result (tid-3457)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32641 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6046-t3457-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1059672842
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1059672747
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1056009660
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1056740901
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1064884247
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1064011684
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1064877086
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1069375524
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1071077306
Thanks @weizhouapache - LGTM.
Tested as root admin, domain admin and user.
Tested by reserving IP as a root admin for a domain admin and user and logged in as the user whom the IP was reserved for and was able to release the IP
Was able to reserve an IP to a project as well and logged into the project and released it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1069397782
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1069702288
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1071170313
> Thanks @weizhouapache - LGTM. Tested as root admin, domain admin and user. Tested by reserving IP as a root admin for a domain admin and user and logged in as the user whom the IP was reserved for and was able to release the IP Was able to reserve an IP to a project as well and logged into the project and released it.
great, thanks for testing ! @Pearl1594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1070903097
<b>Trillian test result (tid-3645)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31527 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6046-t3645-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1071170313
> Thanks @weizhouapache - LGTM. Tested as root admin, domain admin and user. Tested by reserving IP as a root admin for a domain admin and user and logged in as the user whom the IP was reserved for and was able to release the IP Was able to reserve an IP to a project as well and logged into the project and released it.
great, thanks for testing ! @Pearl1594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1061934758
PIng for review @davidjumani @Pearl1594 @rohityadavcloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1056740047
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1059655347
Thanks @weizhouapache, looks great! Can you please raise a PR for documentation for these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez removed a comment on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
nvazquez removed a comment on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1063589313
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1064884247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1063589583
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1069354155
> Code LGTM. Small points:
>
> * When reserving an IP for an account, it would be nice, if the account for which the IP has been reserved has the ability to release the address
> * For a reserved IP address - it would be better if we could hide the Firewall, LB and protforwarding tab - this isn't major, can be addressed later too.
> Thanks @weizhouapache
thanks @Pearl1594 for review
I have addressed your comments
(1) both apis are available for domain admins and regular users, same as associate/disassociate public ip
(2) the tabs on UI and other UI issues (due to vue3 upgrade) has been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1069376093
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1054080965
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1056049010
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1059497491
> LGTM - manually tested:
>
> * Create isolated network
> * Navigate to public IPs -> filter Free IPS -> reserve IP for account
> * Ensure the IP is available for acquiring new public IPs
> * Released IP
>
> Can we add a different color for the Reserved state, like orange? <img alt="Screen Shot 2022-03-04 at 14 50 55" width="320" src="https://user-images.githubusercontent.com/5295080/156815710-2e42a4bf-ea3a-4124-918a-ee821f0445f2.png">
@nvazquez
great, thanks for testing.
Updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1064980776
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1063599349
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1063893906
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1069702588
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1069705860
<b>Trillian Build Failed (tid-3641)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1059679516
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1064876813
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1064929389
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache removed a comment on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache removed a comment on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1063893448
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache removed a comment on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache removed a comment on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1064876813
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1063893906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1063589583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1064011888
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1064087583
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1064928768
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1064079256
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1056070486
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1063589313
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1063925360
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6046: New feature: Reserve and release Public IPs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6046:
URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1070903097
<b>Trillian test result (tid-3645)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31527 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6046-t3645-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org