[GitHub] [beam] alexeyinkin commented on a diff in pull request #24919: [ToB][Frontend] Gradle tasks for ToB frontend

[GitBox <gi...@apache.org>]

alexeyinkin commented on code in PR #24919:
URL: https://github.com/apache/beam/pull/24919#discussion_r1063269091


##########
learning/tour-of-beam/frontend/build.gradle.kts:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+evaluationDependsOn(":playground:frontend:playground_components")
+
+tasks.register("generate") {
+  dependsOn(":playground:frontend:playground_components:generate")
+
+  dependsOn("generateCode")
+
+  group = "build"
+  description = "Generates all generated files."
+}
+
+tasks.register("analyze") {
+  dependsOn(":playground:frontend:playground_components:generateCode")
+  dependsOn("generateCode")
+
+  group = "verification"
+  description = "Analyze dart code"
+
+  doLast {
+    exec {
+      // Exact paths instead of '.' so it does not go into playground_components

Review Comment:
   Delete such comments here and in Playground so we can copy tasks between them.



##########
learning/tour-of-beam/frontend/build.gradle.kts:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+evaluationDependsOn(":playground:frontend:playground_components")
+
+tasks.register("generate") {
+  dependsOn(":playground:frontend:playground_components:generate")
+
+  dependsOn("generateCode")
+
+  group = "build"
+  description = "Generates all generated files."
+}
+
+tasks.register("analyze") {
+  dependsOn(":playground:frontend:playground_components:generateCode")
+  dependsOn("generateCode")
+
+  group = "verification"
+  description = "Analyze dart code"
+
+  doLast {
+    exec {
+      // Exact paths instead of '.' so it does not go into playground_components
+      executable("dart")
+      args("analyze", "lib", "test")
+    }
+  }
+}
+
+tasks.register("pubGet") {
+  group = "build"
+  description = "Get packages for the playground frontend project"

Review Comment:
   Strip project names from descriptions so the same ones can be used for both Playground and ToB.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org