You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/08/17 07:20:42 UTC
[GitHub] [incubator-hugegraph-toolchain] BestBurning opened a new pull request, #325: fix: Line check argument show detail info
BestBurning opened a new pull request, #325:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/325
fix line cheack argument, then it'll show detail info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on a diff in pull request #325: fix: Line check argument show detail info
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #325:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/325#discussion_r947576774
##########
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/reader/line/Line.java:
##########
@@ -37,7 +38,9 @@ public Line(String rawLine, String[] names, Object[] values) {
E.checkArgumentNotNull(names, "The names can't be null");
E.checkArgumentNotNull(values, "The values can't be null");
E.checkArgument(names.length == values.length,
- "The length of names %s should be same as values %s");
+ "The length of names %s should be same as values %s",
+ Arrays.toString(names),
+ Arrays.toString(values));
Review Comment:
please keep the original align style, thanks
and better to show/paste the difference in comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] javeme commented on a diff in pull request #325: refact: show detail info when parse line meet error
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #325:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/325#discussion_r985083501
##########
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/reader/line/Line.java:
##########
@@ -37,7 +38,9 @@ public Line(String rawLine, String[] names, Object[] values) {
E.checkArgumentNotNull(names, "The names can't be null");
E.checkArgumentNotNull(values, "The values can't be null");
E.checkArgument(names.length == values.length,
- "The length of names %s should be same as values %s");
+ "The length of names %s should be same as values %s",
+ Arrays.toString(names),
Review Comment:
prefer to add if-statement check to avoid unnecessary toString() call:
```java
if (names.length != values.length) {
E.checkArgument(...);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] codecov[bot] commented on pull request #325: refact: show detail info when parse line meet error
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #325:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/325#issuecomment-1217660856
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/325?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#325](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/325?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f1c2601) into [master](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/commit/278fbea3355d1dbdfee6861c146b6be47a40bf64?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (278fbea) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #325 +/- ##
============================================
+ Coverage 67.49% 67.53% +0.04%
- Complexity 877 878 +1
============================================
Files 86 86
Lines 4024 4026 +2
Branches 475 475
============================================
+ Hits 2716 2719 +3
Misses 1104 1104
+ Partials 204 203 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/com/baidu/hugegraph/loader/reader/line/Line.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvbG9hZGVyL3JlYWRlci9saW5lL0xpbmUuamF2YQ==) | `77.41% <100.00%> (+5.00%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] github-actions[bot] commented on pull request #325: refact: show detail info when parse line meet error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #325:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/325#issuecomment-1297679578
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on pull request #325: refact: show detail info when parse line meet error
Posted by GitBox <gi...@apache.org>.
imbajin commented on PR #325:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/325#issuecomment-1231276097
Any update with this pr? Just some tiny comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] github-actions[bot] commented on pull request #325: refact: show detail info when parse line meet error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #325:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/325#issuecomment-1262810698
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin merged pull request #325: refact: show detail info when parse line meet error
Posted by GitBox <gi...@apache.org>.
imbajin merged PR #325:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org