You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2024/09/12 12:47:50 UTC

(commons-dbutils) 01/03: Convert cascading if-else to switch

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbutils.git

commit fca2db017fd8b759a16f4121f546d4920ea78398
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Sep 12 08:42:13 2024 -0400

    Convert cascading if-else to switch
---
 .../dbutils/handlers/properties/DatePropertyHandler.java     | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/commons/dbutils/handlers/properties/DatePropertyHandler.java b/src/main/java/org/apache/commons/dbutils/handlers/properties/DatePropertyHandler.java
index 95cb322..aefb2f2 100644
--- a/src/main/java/org/apache/commons/dbutils/handlers/properties/DatePropertyHandler.java
+++ b/src/main/java/org/apache/commons/dbutils/handlers/properties/DatePropertyHandler.java
@@ -37,12 +37,18 @@ public class DatePropertyHandler implements PropertyHandler {
         final Date dateValue = (Date) value;
         final long time = dateValue.getTime();
 
-        if (JAVA_SQL_DATE.equals(targetType)) {
+        switch (targetType) {
+        case JAVA_SQL_DATE:
             value = new java.sql.Date(time);
-        } else if (JAVA_SQL_TIME.equals(targetType)) {
+            break;
+        case JAVA_SQL_TIME:
             value = new java.sql.Time(time);
-        } else if (JAVA_SQL_TIMESTAMP.equals(targetType)) {
+            break;
+        case JAVA_SQL_TIMESTAMP:
             value = new Timestamp(time);
+            break;
+        default:
+            break;
         }
 
         return value;