[GitHub] kafka pull request #3097: KAFKA-5134 Replace zkClient.getChildren method wit...

[baluchicken <gi...@git.apache.org>]

GitHub user baluchicken opened a pull request:

    https://github.com/apache/kafka/pull/3097

    KAFKA-5134 Replace zkClient.getChildren method with zkUtils.getChildren

    @ijuma plz review. I also created a version where I didn't refactor the  getPartitionAssignmentForTopics and the getConsumersPerTopic methods, but I thought maybe it is a good idea to do and move the logic (where there is no ZK connection) to the ZkUtils Object.
    About the two new methods, I wanted to make them private and visible only for testing, but because the tests where I use them are not in the same package I couldn't do it. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/baluchicken/kafka-1 KAFKA-5134-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3097.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3097
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3097: KAFKA-5134 Replace zkClient.getChildren method wit...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/3097


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---