You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Thomas Peuss (JIRA)" <ji...@apache.org> on 2008/03/18 12:23:24 UTC
[jira] Created: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
--------------------------------------------------------------------------------------
Key: SOLR-505
URL: https://issues.apache.org/jira/browse/SOLR-505
Project: Solr
Issue Type: Bug
Components: search
Affects Versions: 1.3
Reporter: Thomas Peuss
The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SOLR-505) Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
Posted by Noble Paul നോബിള് नोब्ळ् <no...@gmail.com>.
+1 for
{code}rsp.setHttpCaching(true/false);{code}
--Noble
On Thu, May 22, 2008 at 7:19 AM, Otis Gospodnetic (JIRA)
<ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598884#action_12598884 ]
>
> Otis Gospodnetic commented on SOLR-505:
> ---------------------------------------
>
> Yes, I think we should get this in 1.3.
> I took a quick look at the patch and saw this:
>
> {code}rsp.setAvoidHttpCaching(false);{code}
>
> Am I the only one who has a harder time reading negative methods like this, esp. when they take false?
> Would it not be nicer to just have:
> {code}rsp.setHttpCaching(true/false);{code}
> or even
> {code}rsp.httpCachingOn() + rsp.httpCachingOff(){code}
>
> Similarly, instead of {code}isAvoidHttpCaching(){code} have {code}isHttpCachingOn(){code}
>
> I know this is "just naming", but I think it helps with readability a bit.
>
> I notice the unit test mods are not in the patch. Is there no need to test the modified behaviour?
>
>
>> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
>> --------------------------------------------------------------------------------------
>>
>> Key: SOLR-505
>> URL: https://issues.apache.org/jira/browse/SOLR-505
>> Project: Solr
>> Issue Type: Bug
>> Components: search
>> Affects Versions: 1.3
>> Reporter: Thomas Peuss
>> Fix For: 1.3
>>
>> Attachments: SOLR-505.patch, SOLR-505.patch
>>
>>
>> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
>> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "Sean Timm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598751#action_12598751 ]
Sean Timm commented on SOLR-505:
--------------------------------
It worked well for me. I'd like to see it included in 1.3.
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Attachments: SOLR-505.patch, SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "Thomas Peuss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598951#action_12598951 ]
Thomas Peuss commented on SOLR-505:
-----------------------------------
I don't think that is a good idea to include the patch for SOLR-505 with the patch for SOLR-502. Sean included it only because he depends on the code changes we do with SOLR-505.
I would like to see the following:
* Rework SOLR-505 like Otis mentioned. As we only change the "naming" and not the overall approach I am fine with that. I can do that tomorrow.
* Commit SOLR-505
* Rework SOLR-502 to use the changed API and to be compatible with trunk
* Commit SOLR-505
SOLR-505 and SOLR-502 have different goals. So combining them makes no big sense to me and might confuse people.
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Assignee: Otis Gospodnetic
> Fix For: 1.3
>
> Attachments: SOLR-505.patch, SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Otis Gospodnetic updated SOLR-505:
----------------------------------
Thomas - just to make it more obvious - it looks like Sean Timm included your patch in SOLR-502, so I will look at patches provided with SOLR-502 instead of expecting code/patch changes here under SOLR-505. I hope that's OK and that it simplifies things.
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Assignee: Otis Gospodnetic
> Fix For: 1.3
>
> Attachments: SOLR-505.patch, SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (SOLR-505) Give RequestHandlers the possiblity
to suppress the generation of HTTP caching headers
Posted by Thomas Peuss <th...@peuss.de>.
Hi Otis!
Otis Gospodnetic (JIRA) schrieb:
> Resolution: Fixed
>
> Danke, Thomas.
You are welcome... ;-)
I have not expected such a fast response time for a patch that was
lingering three months in JIRA without a comment...
CU
Thomas
[jira] Resolved: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Otis Gospodnetic resolved SOLR-505.
-----------------------------------
Resolution: Fixed
Danke, Thomas.
Committed revision 659657.
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Assignee: Otis Gospodnetic
> Fix For: 1.3
>
> Attachments: SOLR-505.patch, SOLR-505.patch, SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "Thomas Peuss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598683#action_12598683 ]
Thomas Peuss commented on SOLR-505:
-----------------------------------
Any further comments on this? Good enough?
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Attachments: SOLR-505.patch, SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "Thomas Peuss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Peuss updated SOLR-505:
------------------------------
Attachment: SOLR-505.patch
* Reworked naming like Otis suggested
* Some other minor changes
* Added tests to check the new code (this was the hardest part)
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Assignee: Otis Gospodnetic
> Fix For: 1.3
>
> Attachments: SOLR-505.patch, SOLR-505.patch, SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "David Smiley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598990#action_12598990 ]
David Smiley commented on SOLR-505:
-----------------------------------
Otis, I completely agree with your comment on the naming. It's a bit odd. I was thinking the same thing before your comment and I should of said something too; don't know why I didn't.
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Assignee: Otis Gospodnetic
> Fix For: 1.3
>
> Attachments: SOLR-505.patch, SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Otis Gospodnetic updated SOLR-505:
----------------------------------
Fix Version/s: 1.3
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Assignee: Otis Gospodnetic
> Fix For: 1.3
>
> Attachments: SOLR-505.patch, SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Otis Gospodnetic reassigned SOLR-505:
-------------------------------------
Assignee: Otis Gospodnetic
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Assignee: Otis Gospodnetic
> Fix For: 1.3
>
> Attachments: SOLR-505.patch, SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "Thomas Peuss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579918#action_12579918 ]
Thomas Peuss commented on SOLR-505:
-----------------------------------
BTW: The patch uses _avoidHttpCaching=true_ as default as this is the safer approach. The patch only set this to _false_ for the search handlers.
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Attachments: SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "Thomas Peuss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Peuss updated SOLR-505:
------------------------------
Attachment: SOLR-505.patch
* Updated to trunk
* Emits no-cache headers in case of Exeptions
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Attachments: SOLR-505.patch, SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "Sean Timm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580070#action_12580070 ]
Sean Timm commented on SOLR-505:
--------------------------------
Should errors be cached? Certainly some are transient and shouldn't be.
In the SolrDispatchFilter,
{code}
if( solrRsp.getException() != null ) {
sendError( (HttpServletResponse)response, solrRsp.getException() );
}
{code}
the Expires and Cache-Control headers could be reset as in HttpCacheHeaderUtil.checkAvoidHttpCaching(...).
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Attachments: SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579867#action_12579867 ]
Yonik Seeley commented on SOLR-505:
-----------------------------------
+1 on the general approach.
Distributed search will probably need to avoid caching as well.
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Attachments: SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "Thomas Peuss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Peuss updated SOLR-505:
------------------------------
Attachment: SOLR-505.patch
Draft version of a patch.
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Attachments: SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SOLR-505) Give RequestHandlers the
possiblity to suppress the generation of HTTP caching headers
Posted by "Thomas Peuss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580718#action_12580718 ]
tpeuss edited comment on SOLR-505 at 3/20/08 3:18 AM:
------------------------------------------------------------
* Updated to trunk
* Emits _no-cache_ headers in case of exceptions
was (Author: tpeuss):
* Updated to trunk
* Emits no-cache headers in case of Exeptions
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Attachments: SOLR-505.patch, SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599060#action_12599060 ]
Otis Gospodnetic commented on SOLR-505:
---------------------------------------
Thomas - very much fine with me. I, too, was wondering why Sean incorporated your patch in his, but assumed you guys had a deal of some kind (e.g. perhaps you were colleagues working in sync).
I'll wait for the new patch, commit, resolve this issue and then I'll move over to SOLR-502 and wait for Sean to make a new and clean patch for that timeout functionality.
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Assignee: Otis Gospodnetic
> Fix For: 1.3
>
> Attachments: SOLR-505.patch, SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-505) Give RequestHandlers the possiblity to
suppress the generation of HTTP caching headers
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598884#action_12598884 ]
Otis Gospodnetic commented on SOLR-505:
---------------------------------------
Yes, I think we should get this in 1.3.
I took a quick look at the patch and saw this:
{code}rsp.setAvoidHttpCaching(false);{code}
Am I the only one who has a harder time reading negative methods like this, esp. when they take false?
Would it not be nicer to just have:
{code}rsp.setHttpCaching(true/false);{code}
or even
{code}rsp.httpCachingOn() + rsp.httpCachingOff(){code}
Similarly, instead of {code}isAvoidHttpCaching(){code} have {code}isHttpCachingOn(){code}
I know this is "just naming", but I think it helps with readability a bit.
I notice the unit test mods are not in the patch. Is there no need to test the modified behaviour?
> Give RequestHandlers the possiblity to suppress the generation of HTTP caching headers
> --------------------------------------------------------------------------------------
>
> Key: SOLR-505
> URL: https://issues.apache.org/jira/browse/SOLR-505
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Thomas Peuss
> Fix For: 1.3
>
> Attachments: SOLR-505.patch, SOLR-505.patch
>
>
> The code from SOLR-127 emits HTTP cache headers for all handlers if configured. We should not emit cache related headers for update request handlers. Partial responses (coming from the Timeout request stuff) should not be cached as well.
> To solve this problem we can simply add two methods to the SolrQueryResponse class (like void setAvoidHTTPCaching(boolean) and boolean isAvoidHTTPCaching() - the default for the value would be false). The update request handlers should set this to true all the time. The partial response stuff can set this to true as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.