[GitHub] [airflow] chattarajoy commented on a change in pull request #10599: Added jupytercmd and fixed task failure when notify set as true in qubole operator

[GitBox <gi...@apache.org>]

chattarajoy commented on a change in pull request #10599:
URL: https://github.com/apache/airflow/pull/10599#discussion_r479453510



##########
File path: airflow/providers/qubole/hooks/qubole.py
##########
@@ -239,12 +241,12 @@ def create_cmd_args(self, context):
                     inplace_args = value
                 elif key == 'tags':
                     self._add_tags(tags, value)
+                elif key == 'notify':
+                    if value is True: # pylint: disable=too-many-nested-blocks

Review comment:
       Add a test case for this?

##########
File path: airflow/providers/qubole/operators/qubole.py
##########
@@ -106,13 +106,15 @@ class QuboleOperator(BaseOperator):
                 script_location is supplied
         sparkcmd:
             :program: the complete Spark Program in Scala, R, or Python
-            :cmdline: spark-submit command line, all required information must be specify
+            :cmdline: spark-submit command line, all required arguments must be specify
                 in cmdline itself.
             :sql: inline sql query
             :script_location: s3 location containing query statement
             :language: language of the program, Scala, R, or Python
             :app_id: ID of an Spark job server app
-            :arguments: spark-submit command line arguments
+            :arguments: spark-submit command line arguments.
+                If `cmdline` is selected, this should not be used because all
+                required arguments and configurations are to be passed in the `cmdline` itself.
             :user_program_arguments: arguments that the user program takes in
             :macros: macro values which were used in query

Review comment:
       Add parameters for jupytercmd as well




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org