You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/01 11:03:54 UTC
[GitHub] [incubator-hudi] XuQianJin-Stars opened a new pull request #1168:
[HUDI-463] Redo hudi-utilities log statements using SLF4J
XuQianJin-Stars opened a new pull request #1168: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1168
## What is the purpose of the pull request
Redo hudi-utilities log statements using SLF4J.
## Brief change log
Modify AnnotationLocation checkstyle rule in checkstyle.xml
## Verify this pull request
Use existing tests to verify the original module.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] smarthi commented on issue #1168: [HUDI-463] Redo
hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
smarthi commented on issue #1168: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1168#issuecomment-570076813
Please fix the incorrect imports throughtout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] XuQianJin-Stars opened a new pull request #1168:
[HUDI-463] Redo hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars opened a new pull request #1168: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1168
## What is the purpose of the pull request
Redo hudi-utilities log statements using SLF4J.
## Brief change log
Modify AnnotationLocation checkstyle rule in checkstyle.xml
## Verify this pull request
Use existing tests to verify the original module.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] XuQianJin-Stars commented on issue #1168:
[HUDI-463] Redo hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on issue #1168: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1168#issuecomment-570109340
hi, @smarthi Thank you very much, I addressed commits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] XuQianJin-Stars closed pull request #1168:
[HUDI-463] Redo hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars closed pull request #1168: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1168
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] XuQianJin-Stars commented on issue #1168:
[HUDI-463] Redo hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on issue #1168: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1168#issuecomment-570125816
> Hi @XuQianJin-Stars firstly, please verify the log print is correct after replacing with slf4j in your local.
well, ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1168: [HUDI-463]
Redo hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1168: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1168#issuecomment-570111643
Same question here.. Have we verified the logs actually show up on the demo or some end-end test? the tests could be passing, sure.. since this is a logging only change.. but how are we ensuring each of these modules continues to log correctly? cc @leesf @yanghua
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] smarthi commented on a change in pull request
#1168: [HUDI-463] Redo hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
smarthi commented on a change in pull request #1168: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1168#discussion_r362338554
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/HDFSParquetImporter.java
##########
@@ -59,14 +57,16 @@
import java.util.List;
import java.util.Properties;
+import parquet.org.slf4j.Logger;
+import parquet.org.slf4j.LoggerFactory;
Review comment:
is this the correct import? Are we not using the standard org.slf4j.* ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1168: [HUDI-463] Redo
hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1168: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1168#issuecomment-570125630
Hi @XuQianJin-Stars firstly, please verify the log print is correct after replacing with slf4j in your local.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] XuQianJin-Stars closed pull request #1168:
[HUDI-463] Redo hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars closed pull request #1168: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1168
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on issue #1168: [HUDI-463] Redo
hudi-utilities log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on issue #1168: [HUDI-463] Redo hudi-utilities log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1168#issuecomment-570736304
@XuQianJin-Stars Thanks for opening this PR, Could you please reopen and merge this PR to redo-log branch? more context can be found https://lists.apache.org/thread.html/9dc1f3a590413a5224a1a5ad835353e11b2b754e1ec7ad1ca0a55053%40%3Cdev.hudi.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services