You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by jm...@apache.org on 2018/02/20 00:51:38 UTC
[incubator-plc4x] branch master updated (ac10e6e -> fb29bf1)
This is an automated email from the ASF dual-hosted git repository.
jmclean pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git.
from ac10e6e one statement per line (sonarqube)
new ca98538 simplify
new fb29bf1 unneeded imports
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../java/org/apache/plc4x/java/examples/kafkabridge/KafkaBridge.java | 4 +---
.../test/java/org/apache/plc4x/java/api/messages/PlcResponseTest.java | 1 -
.../org/apache/plc4x/java/isoontcp/netty/IsoOnTcpProtocolTest.java | 1 -
.../apache/plc4x/java/isotp/netty/model/tpdus/IsotpModelTests.java | 1 -
4 files changed, 1 insertion(+), 6 deletions(-)
--
To stop receiving notification emails like this one, please contact
jmclean@apache.org.
[incubator-plc4x] 02/02: unneeded imports
Posted by jm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jmclean pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git
commit fb29bf19121afc81ebb7b8d9598d83bfb4a62f23
Author: Justin Mclean <jm...@apache.org>
AuthorDate: Tue Feb 20 11:51:31 2018 +1100
unneeded imports
---
.../test/java/org/apache/plc4x/java/api/messages/PlcResponseTest.java | 1 -
.../java/org/apache/plc4x/java/isoontcp/netty/IsoOnTcpProtocolTest.java | 1 -
.../org/apache/plc4x/java/isotp/netty/model/tpdus/IsotpModelTests.java | 1 -
3 files changed, 3 deletions(-)
diff --git a/plc4j/api/src/test/java/org/apache/plc4x/java/api/messages/PlcResponseTest.java b/plc4j/api/src/test/java/org/apache/plc4x/java/api/messages/PlcResponseTest.java
index 22bab30..7b887a3 100644
--- a/plc4j/api/src/test/java/org/apache/plc4x/java/api/messages/PlcResponseTest.java
+++ b/plc4j/api/src/test/java/org/apache/plc4x/java/api/messages/PlcResponseTest.java
@@ -33,7 +33,6 @@ import static org.hamcrest.core.IsEqual.equalTo;
import static org.hamcrest.core.IsNull.notNullValue;
import static org.junit.Assert.assertThat;
import static org.junit.Assert.fail;
-import static org.mockito.ArgumentMatchers.isNotNull;
import static org.mockito.Mockito.mock;
public class PlcResponseTest {
diff --git a/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isoontcp/netty/IsoOnTcpProtocolTest.java b/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isoontcp/netty/IsoOnTcpProtocolTest.java
index 3d7380d..b2ae4b2 100644
--- a/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isoontcp/netty/IsoOnTcpProtocolTest.java
+++ b/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isoontcp/netty/IsoOnTcpProtocolTest.java
@@ -29,7 +29,6 @@ import org.apache.plc4x.java.api.exceptions.PlcProtocolException;
import org.apache.plc4x.java.isoontcp.netty.model.IsoOnTcpMessage;
import org.apache.plc4x.java.netty.NettyTestBase;
import org.apache.plc4x.test.FastTests;
-import org.hamcrest.core.StringContains;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.slf4j.LoggerFactory;
diff --git a/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isotp/netty/model/tpdus/IsotpModelTests.java b/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isotp/netty/model/tpdus/IsotpModelTests.java
index c4a62f4..311eec4 100644
--- a/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isotp/netty/model/tpdus/IsotpModelTests.java
+++ b/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isotp/netty/model/tpdus/IsotpModelTests.java
@@ -39,7 +39,6 @@ import static org.hamcrest.collection.IsEmptyCollection.empty;
import static org.hamcrest.collection.IsIterableContainingInOrder.contains;
import static org.hamcrest.core.Is.is;
import static org.hamcrest.core.IsEqual.equalTo;
-import static org.hamcrest.core.IsNot.not;
import static org.junit.Assert.assertThat;
public class IsotpModelTests {
--
To stop receiving notification emails like this one, please contact
jmclean@apache.org.
[incubator-plc4x] 01/02: simplify
Posted by jm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jmclean pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git
commit ca98538aec2ed2959255cd881852f5cb57e42ed9
Author: Justin Mclean <jm...@apache.org>
AuthorDate: Tue Feb 20 11:51:04 2018 +1100
simplify
---
.../java/org/apache/plc4x/java/examples/kafkabridge/KafkaBridge.java | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/examples/kafka-bridge/src/main/java/org/apache/plc4x/java/examples/kafkabridge/KafkaBridge.java b/examples/kafka-bridge/src/main/java/org/apache/plc4x/java/examples/kafkabridge/KafkaBridge.java
index 9466419..509a394 100644
--- a/examples/kafka-bridge/src/main/java/org/apache/plc4x/java/examples/kafkabridge/KafkaBridge.java
+++ b/examples/kafka-bridge/src/main/java/org/apache/plc4x/java/examples/kafkabridge/KafkaBridge.java
@@ -94,9 +94,7 @@ public class KafkaBridge {
TStream<Byte> source = top.poll(plcSupplier, config.getPollingInterval(), TimeUnit.MILLISECONDS);
// Convert the byte into a string.
- TStream<String> stringSource = source.map(value -> {
- return Byte.toString(value);
- });
+ TStream<String> stringSource = source.map(value -> Byte.toString(value));
// Publish the stream to the topic. The String tuple is the message value.
kafka.publish(stringSource, config.getKafkaConfig().getTopicName());
--
To stop receiving notification emails like this one, please contact
jmclean@apache.org.