You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "unbridled-41 (via GitHub)" <gi...@apache.org> on 2026/10/09 22:17:48 UTC
[PR] fix(topic): answer a topic create with the stored perm, cluster and type [rocketmq-dashboard]
unbridled-41 opened a new pull request, #6009:
URL: https://github.com/apache/rocketmq-dashboard/pull/6009
### Which Issue(s) This PR Fixes
Fixes #6008
### Problem / Evidence
```java
// createTopic (before): only id/queues back-filled
topic.setId(entity.getId());
topic.setWriteQueues(writeQueues);
topic.setReadQueues(readQueues);
return topic;
```
```
RocketMQAdminClientImplTest: createTopicShouldAnswerWithTheStoredPermClusterAndTypeTest
expected: RW but was: null
```
The update path already documents the principle for the remark ("so a clear or an omitted remark cannot be mistaken for a value the update did not write").
### Root cause / Fix
Neither write path re-projected the stored columns. Copy the persisted cluster, permission and type onto the response (the type only when the request omitted it, so an explicit value is echoed as submitted).
### Priority and scoring
**PRIORITY 70** - impact 26/40 (API clients and agents read wrong facts from the create response), blast radius 16/20 (every create and update through the REST API, the AI tools and rmqctl), reproducibility 18/20 (pinned by the new test), maintenance value 10/20. **FIX_CONFIDENCE 80**.
### Tests
`cd server && mvn -o -B -ntp test -Dtest='RocketMQAdminClientImplTest'` -> `Tests run: 81, Failures: 0, Errors: 0`; the new case fails before the change and passes after it; `checkstyle:check` passes.
### Risk
The response now carries three more populated fields; nothing that could previously be read as "unset" is lost (a genuinely absent stored value stays null).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(topic): answer a topic create with the stored perm, cluster and type [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #6009:
URL: https://github.com/apache/rocketmq-dashboard/pull/6009#issuecomment-6090221459
### CI status of this PR
`Backend Tests (Java 21)` — **pass**; the change-specific commands and their results are in the Tests section of the description.
The four remaining red jobs are red for every branch, including `rocketmq-studio` itself:
- `Backend Build (Java 21)` — the `binary-license-gate` antrun step fails on a list of third-party jars (`spring-ai-*`, `swagger-ui`, `tencentcloud-sdk-*`, `zstd-jni`, ... : "missing complete upstream LICENSE/COPYING; a POM name or link is not a substitute"). This PR touches no build configuration; tracked by #5341.
- `Frontend Build (Node 20)` / `Frontend Docker Build` — the frontend licence manifest check fails the same way on branches that do not touch `web/` at all; tracked by #5346.
- `rmqctl Build (Go)` — `cmd` `TestMessageQueryCompletenessWarningTest` yaml subtests: `got {"items":[{"size":"3",...}]}, want {"size":3,...}`, i.e. the YAML renderer writes numbers as quoted strings where the test expects integer literals. Reproduced locally with `cd rmqctl && go test ./cmd/` from a checkout whose `rmqctl/` tree is byte-identical to `rocketmq-studio`'s, and owned by open PR #5850 ("keep yaml numbers unquoted").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(topic): answer a topic create with the stored perm, cluster and type [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #6009:
URL: https://github.com/apache/rocketmq-dashboard/pull/6009#issuecomment-6091430583
### Verification on the final commit (branch + commit + command results)
Every command from the description re-run on a fresh worktree of this branch (`git worktree add <dir> fork/<branch>`, no local modifications), at commit `e46d88c881`:
| command | exit | result |
| --- | --- | --- |
| `cd server && mvn -o -B -ntp test -Dtest='RocketMQAdminClientImplTest'` | 0 | `Tests run: 81, Failures: 0, Errors: 0, Skipped: 0 · BUILD SUCCESS` |
CI note: on this repository the `Backend Build` (binary-license-gate), `Frontend Build` / `Frontend Docker Build` (licence manifest) and `rmqctl Build` (YAML renderer quoting) jobs are red for every branch, trunk included; the module-level commands above are unaffected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(topic): answer a topic create with the stored perm, cluster and type [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #6009: fix(topic): answer a topic create with the stored perm, cluster and type
URL: https://github.com/apache/rocketmq-dashboard/pull/6009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(topic): answer a topic create with the stored perm, cluster and type [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6009:
URL: https://github.com/apache/rocketmq-dashboard/pull/6009#issuecomment-6227210788
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org