You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/02 02:26:01 UTC
[GitHub] [arrow-datafusion] yjshen opened a new pull request #2134: WIP: Reduce sort memory usage v2 by @richox
yjshen opened a new pull request #2134:
URL: https://github.com/apache/arrow-datafusion/pull/2134
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Another trial to reduce memory usage during the sort.
From @richox
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2134: WIP: Reduce sort memory usage v2 by @richox
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #2134:
URL: https://github.com/apache/arrow-datafusion/pull/2134#issuecomment-1086616543
This looks very cool -- thank you @yjshen and @richox for working on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen commented on pull request #2134: WIP: Reduce sort memory usage v2 by @richox
Posted by GitBox <gi...@apache.org>.
yjshen commented on pull request #2134:
URL: https://github.com/apache/arrow-datafusion/pull/2134#issuecomment-1086511409
```
cargo run --release --features "mimalloc" --bin tpch -- benchmark datafusion --iterations 3 --path ../tpch-parquet/ --format parquet --query 1 --batch-size 4096
```
```
Finished release [optimized] target(s) in 0.07s
Running `target/release/tpch benchmark datafusion --iterations 3 --path ../tpch-parquet/ --format parquet --query 1 --batch-size 4096`
Running benchmarks with the following options: DataFusionBenchmarkOpt { query: 1, debug: false, iterations: 3, partitions: 2, batch_size: 4096, path: "../tpch-parquet/", file_format: "parquet", mem_table: false, output_path: None }
Query 1 iteration 0 took 36483.0 ms and returned 6001214 rows
Query 1 iteration 1 took 36783.2 ms and returned 6001214 rows
Query 1 iteration 2 took 36400.4 ms and returned 6001214 rows
Query 1 avg time: 36555.52 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen edited a comment on pull request #2134: WIP: Reduce sort memory usage v2 by @richox
Posted by GitBox <gi...@apache.org>.
yjshen edited a comment on pull request #2134:
URL: https://github.com/apache/arrow-datafusion/pull/2134#issuecomment-1086511409
```
cargo run --release --features "mimalloc" --bin tpch -- benchmark datafusion --iterations 3 --path ../tpch-parquet/ --format parquet --query 1 --batch-size 4096
```
Without this PR:
```
Running benchmarks with the following options: DataFusionBenchmarkOpt { query: 1, debug: false, iterations: 3, partitions: 2, batch_size: 4096, path: "../../tpch-parquet/", file_format: "parquet", mem_table: false, output_path: None }
Query 1 iteration 0 took 2851.7 ms and returned 6001214 rows
Query 1 iteration 1 took 2817.7 ms and returned 6001214 rows
Query 1 iteration 2 took 2735.9 ms and returned 6001214 rows
Query 1 avg time: 2801.75 ms
```
With this PR:
```
Finished release [optimized] target(s) in 0.07s
Running `target/release/tpch benchmark datafusion --iterations 3 --path ../tpch-parquet/ --format parquet --query 1 --batch-size 4096`
Running benchmarks with the following options: DataFusionBenchmarkOpt { query: 1, debug: false, iterations: 3, partitions: 2, batch_size: 4096, path: "../tpch-parquet/", file_format: "parquet", mem_table: false, output_path: None }
Query 1 iteration 0 took 36483.0 ms and returned 6001214 rows
Query 1 iteration 1 took 36783.2 ms and returned 6001214 rows
Query 1 iteration 2 took 36400.4 ms and returned 6001214 rows
Query 1 avg time: 36555.52 ms
```
There appears to be a serious deterioration in performance 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org