You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2010/04/13 23:35:50 UTC
[jira] Created: (HADOOP-6703) Prevent renaming a file, symlink or
directory to itself
Prevent renaming a file, symlink or directory to itself
-------------------------------------------------------
Key: HADOOP-6703
URL: https://issues.apache.org/jira/browse/HADOOP-6703
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Eli Collins
Assignee: Eli Collins
Priority: Minor
Fix For: 0.22.0
Per HDFS-1088 let's throw a FileAlreadyExistsException if renaming a file, symlink or directory to itself, or a symlink to the file it links to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-6703) Prevent renaming a file, symlink or
directory to itself
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861679#action_12861679 ]
Suresh Srinivas commented on HADOOP-6703:
-----------------------------------------
+1 for the patch.
> Prevent renaming a file, symlink or directory to itself
> -------------------------------------------------------
>
> Key: HADOOP-6703
> URL: https://issues.apache.org/jira/browse/HADOOP-6703
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-6703-1.patch, hadoop-6703-2.patch, hadoop-6703-3.patch
>
>
> Per HDFS-1088 let's throw a FileAlreadyExistsException if renaming a file, symlink or directory to itself, or a symlink to the file it links to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6703) Prevent renaming a file, symlink or
directory to itself
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859446#action_12859446 ]
Suresh Srinivas commented on HADOOP-6703:
-----------------------------------------
Eli, this patch does not apply to trunk. Can you please resubmit the patch.
> Prevent renaming a file, symlink or directory to itself
> -------------------------------------------------------
>
> Key: HADOOP-6703
> URL: https://issues.apache.org/jira/browse/HADOOP-6703
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-6703-1.patch, hadoop-6703-2.patch
>
>
> Per HDFS-1088 let's throw a FileAlreadyExistsException if renaming a file, symlink or directory to itself, or a symlink to the file it links to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6703) Prevent renaming a file, symlink or
directory to itself
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6703:
--------------------------------
Attachment: hadoop-6703-1.patch
Patch attached.
> Prevent renaming a file, symlink or directory to itself
> -------------------------------------------------------
>
> Key: HADOOP-6703
> URL: https://issues.apache.org/jira/browse/HADOOP-6703
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-6703-1.patch
>
>
> Per HDFS-1088 let's throw a FileAlreadyExistsException if renaming a file, symlink or directory to itself, or a symlink to the file it links to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-6703) Prevent renaming a file, symlink or
directory to itself
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-6703:
------------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
I committed the patch. Thank you Eli.
> Prevent renaming a file, symlink or directory to itself
> -------------------------------------------------------
>
> Key: HADOOP-6703
> URL: https://issues.apache.org/jira/browse/HADOOP-6703
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-6703-1.patch, hadoop-6703-2.patch, hadoop-6703-3.patch
>
>
> Per HDFS-1088 let's throw a FileAlreadyExistsException if renaming a file, symlink or directory to itself, or a symlink to the file it links to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6703) Prevent renaming a file, symlink or
directory to itself
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857966#action_12857966 ]
Suresh Srinivas commented on HADOOP-6703:
-----------------------------------------
+1 for the patch.
> Prevent renaming a file, symlink or directory to itself
> -------------------------------------------------------
>
> Key: HADOOP-6703
> URL: https://issues.apache.org/jira/browse/HADOOP-6703
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-6703-1.patch, hadoop-6703-2.patch
>
>
> Per HDFS-1088 let's throw a FileAlreadyExistsException if renaming a file, symlink or directory to itself, or a symlink to the file it links to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-6703) Prevent renaming a file, symlink or
directory to itself
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861656#action_12861656 ]
Hadoop QA commented on HADOOP-6703:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12443017/hadoop-6703-3.patch
against trunk revision 938590.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/485/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/485/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/485/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/485/console
This message is automatically generated.
> Prevent renaming a file, symlink or directory to itself
> -------------------------------------------------------
>
> Key: HADOOP-6703
> URL: https://issues.apache.org/jira/browse/HADOOP-6703
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-6703-1.patch, hadoop-6703-2.patch, hadoop-6703-3.patch
>
>
> Per HDFS-1088 let's throw a FileAlreadyExistsException if renaming a file, symlink or directory to itself, or a symlink to the file it links to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6703) Prevent renaming a file, symlink or
directory to itself
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6703:
--------------------------------
Status: Patch Available (was: Open)
> Prevent renaming a file, symlink or directory to itself
> -------------------------------------------------------
>
> Key: HADOOP-6703
> URL: https://issues.apache.org/jira/browse/HADOOP-6703
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-6703-1.patch, hadoop-6703-2.patch, hadoop-6703-3.patch
>
>
> Per HDFS-1088 let's throw a FileAlreadyExistsException if renaming a file, symlink or directory to itself, or a symlink to the file it links to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6703) Prevent renaming a file, symlink or
directory to itself
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6703:
--------------------------------
Attachment: hadoop-6703-3.patch
Patch attached removed the dependency on HADOOP-6563 and merges with trunk. This one just needs to go in with HDFS-1100 which has a +1.
> Prevent renaming a file, symlink or directory to itself
> -------------------------------------------------------
>
> Key: HADOOP-6703
> URL: https://issues.apache.org/jira/browse/HADOOP-6703
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-6703-1.patch, hadoop-6703-2.patch, hadoop-6703-3.patch
>
>
> Per HDFS-1088 let's throw a FileAlreadyExistsException if renaming a file, symlink or directory to itself, or a symlink to the file it links to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6703) Prevent renaming a file, symlink or
directory to itself
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6703:
--------------------------------
Attachment: hadoop-6703-2.patch
Per HDFS-1088, minor update to report file names in the exceptions.
> Prevent renaming a file, symlink or directory to itself
> -------------------------------------------------------
>
> Key: HADOOP-6703
> URL: https://issues.apache.org/jira/browse/HADOOP-6703
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-6703-1.patch, hadoop-6703-2.patch
>
>
> Per HDFS-1088 let's throw a FileAlreadyExistsException if renaming a file, symlink or directory to itself, or a symlink to the file it links to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira