You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by "John Wass (Jira)" <ji...@apache.org> on 2020/06/23 22:54:00 UTC

[jira] [Commented] (DAFFODIL-2145) Add scalac warnings

    [ https://issues.apache.org/jira/browse/DAFFODIL-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143339#comment-17143339 ] 

John Wass commented on DAFFODIL-2145:
-------------------------------------

I took a pass at this and after just a couple of them (unused import, dead code) there are quite a few changes.  Any objections to splitting this across multiple PRs?

> Add scalac warnings
> -------------------
>
>                 Key: DAFFODIL-2145
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2145
>             Project: Daffodil
>          Issue Type: Bug
>          Components: Infrastructure
>            Reporter: Steve Lawrence
>            Priority: Major
>              Labels: beginner
>
> DAFFODIL-1652 removed the follwoing scalac flag warnings when adding suport for scala 2.12 because the build flags changed:
> * -Ybackend:GenBCode
> * -Ydead-code
> * -Yinline
> * -Yinline-warnings
> * -Yopt:inline-global
> * -Yopt-warnings
> * -Ywarn-inaccessible
> * -Ywarn-infer-any
> * -Ywarn-nullary-override
> * -Ywarn-unused
> * -Ywarn-unused-import
> In some of these cases scala 2.12 just changed the name of the warning (e.g. -Ywarn-unused-import became -Ywarn-unused:imports). We should find the equivalent 2.12 warnings if they exist and add conditional logic to apply the correct flags based on scala version a scala version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)