[I] Unused parameter in function ProjectionDescriptor.createPojoJavaImplementation() [wayang]

["CarloMariaProietti (via GitHub)" <gi...@apache.org>]

CarloMariaProietti opened a new issue, #732:
URL: https://github.com/apache/wayang/issues/732

   The current function is as follows; `inputType` is unused.
   ```
   private static <Input, Output> FunctionDescriptor.SerializableFunction<Input, Output> createPojoJavaImplementation(
               final String[] fieldNames, final BasicDataUnitType<Input> inputType) {
           // Get the names of the fields to be projected.
           if (fieldNames.length != 1) {
               return t -> {
                   throw new IllegalStateException("The projection descriptor currently supports only a single field.");
               };
           }
           final String fieldName = fieldNames[0];
           return new PojoImplementation<>(fieldName);
       }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Unused parameter in function ProjectionDescriptor.createPojoJavaImplementation() [wayang]

["AliRana30 (via GitHub)" <gi...@apache.org>]

AliRana30 commented on issue #732:
URL: https://github.com/apache/wayang/issues/732#issuecomment-5554551934

   @CarloMariaProietti in which file you are exactly getting this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Unused parameter in function ProjectionDescriptor.createPojoJavaImplementation() [wayang]

["AjayBoddeda4 (via GitHub)" <gi...@apache.org>]

AjayBoddeda4 commented on issue #732:
URL: https://github.com/apache/wayang/issues/732#issuecomment-4119784329

   Hi Carlo, thank you for flagging this. I was looking at ProjectionDescriptor while studying the codebase for the DataFrame API proposal.
   The inputType parameter appears to be passed in but never used in the method body — the implementation only uses fieldNames to create the PojoImplementation.
   One possible fix would be to either remove the inputType parameter entirely if it is not needed, or use it to add type validation before the projection — for example checking that the input type actually has the requested field. This would make the DataFrame API's select() operation more robust when users specify column names.
   Would love to contribute a fix for this if guidance is provided on the preferred approach!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Unused parameter in function ProjectionDescriptor.createPojoJavaImplementation() [wayang]

["sawantbandita (via GitHub)" <gi...@apache.org>]

sawantbandita commented on issue #732:
URL: https://github.com/apache/wayang/issues/732#issuecomment-4128300407

   Hi, I would like to work on this issue. I propose to remove the unused `inputType`parameter from the method to improve code clarity, since it is currently not used in the implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org