Re: Getting rid of '$top_builddir' in Makefile.in (was: Problem with r32409 (fix for 'BSD make' compatibility).)

[Stefan Sperling <st...@elego.de>]

On Wed, Aug 27, 2008 at 06:55:32PM -0400, Karl Fogel wrote:
> I've re-subjected this so Makefile.in fetishists will notice the thread.
> 
> Stefan Sperling <st...@elego.de> writes:
> > The only case I can think of where top_builddir could be something
> > other than '.' would be when running make from a different directory
> > than where the generated Makefile resides. E.g. like so:
> >
> > 	cd /tmp && make -f ~/svn/Makefile
> >
> > In which case we'd have to be a bit smarter about setting top_builddir.
> > But I don't expect anyone would need to compile Subversion like that.
> 
> Well, we'd still have relative paths in all the places where we now have
> $top_builddir, so even the above would still work.

I don't understand why it "would still work".

Since it does not work now, how can it still work after getting rid of
$top_builddir?

stsp@ted [/tmp] $ make -f ~/svn/svn-trunk/Makefile
"/home/stsp/svn/svn-trunk/Makefile", line 303: Could not find ./build-outputs.mk
make: fatal errors encountered -- cannot continue

> Folks, does $top_builddir serve any purpose?  If it does, let's put a
> comment there explaining it; if it doesn't, let's just get rid of it.

As already stated, +1.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Getting rid of '$top_builddir' in Makefile.in

[Karl Fogel <kf...@red-bean.com>]

Stefan Sperling <st...@elego.de> writes:
>> Stefan Sperling <st...@elego.de> writes:
>> > The only case I can think of where top_builddir could be something
>> > other than '.' would be when running make from a different directory
>> > than where the generated Makefile resides. E.g. like so:
>> >
>> > 	cd /tmp && make -f ~/svn/Makefile
>> >
>> > In which case we'd have to be a bit smarter about setting top_builddir.
>> > But I don't expect anyone would need to compile Subversion like that.
>> 
>> Well, we'd still have relative paths in all the places where we now have
>> $top_builddir, so even the above would still work.
>
> I don't understand why it "would still work".
>
> Since it does not work now, how can it still work after getting rid of
> $top_builddir?

I just mean that its behavior wouldn't change.  A relative path from cwd
is still a relative path, whether prefixed with "./" or not.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org