You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/22 16:31:24 UTC
[GitHub] [beam] olehborysevych commented on a diff in pull request #24287: [Tour Of Beam] persistence_key for Pg::SaveSnippet
olehborysevych commented on code in PR #24287:
URL: https://github.com/apache/beam/pull/24287#discussion_r1029462231
##########
learning/tour-of-beam/backend/README.md:
##########
@@ -101,7 +103,9 @@ gcloud datastore indexes create ./internal/storage/index.yaml
for endpoint in getSdkList getContentTree getUnitComplete getUserProgress postUnitComplete postUserCode; do
gcloud functions deploy $endpoint --entry-point $endpoint \
--region $REGION --runtime go116 --allow-unauthenticated \
- --trigger-http --set-env-vars="DATASTORE_PROJECT_ID=$PROJECT_ID,GOOGLE_PROJECT_ID=$PROJECT_ID"
+ --trigger-http \
+ --set-env-vars="DATASTORE_PROJECT_ID=$PROJECT_ID,GOOGLE_PROJECT_ID=$PROJECT_ID" \
+ --set-secrets 'PERSISTENCE_KEY_SALT=persistence_key_salt:latest"
Review Comment:
please check mismatching quotation marks
##########
learning/tour-of-beam/backend/README.md:
##########
@@ -86,10 +86,12 @@ Prerequisites:
* Billing API
* Cloud Functions API
* Firebase Admin API
+ * Secret Manager API
- set environment variables:
* PROJECT_ID: GCP id
* REGION: the region, "us-central1" fe
- existing setup of Playground backend in a project
+ - create a secret `persistence_key_salt` in Secret Manager
Review Comment:
@eantyshev what are the requirements for the key salt value?
##########
learning/tour-of-beam/backend/README.md:
##########
@@ -101,7 +103,9 @@ gcloud datastore indexes create ./internal/storage/index.yaml
for endpoint in getSdkList getContentTree getUnitComplete getUserProgress postUnitComplete postUserCode; do
gcloud functions deploy $endpoint --entry-point $endpoint \
--region $REGION --runtime go116 --allow-unauthenticated \
- --trigger-http --set-env-vars="DATASTORE_PROJECT_ID=$PROJECT_ID,GOOGLE_PROJECT_ID=$PROJECT_ID"
+ --trigger-http \
+ --set-env-vars="DATASTORE_PROJECT_ID=$PROJECT_ID,GOOGLE_PROJECT_ID=$PROJECT_ID" \
+ --set-secrets 'PERSISTENCE_KEY_SALT=persistence_key_salt:latest"
Review Comment:
can we have some kind of fallback in case we will decide to go without a salt from secrets? just asking ))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org